Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rustfmt malloc_size_of & derive #21615

Merged
merged 1 commit into from Sep 5, 2018
Merged

Conversation

@pyfisch
Copy link
Contributor

pyfisch commented Sep 5, 2018

Part of #21373. Formatting looks good.


This change is Reviewable

@highfive
Copy link

highfive commented Sep 5, 2018

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
@@ -850,7 +888,8 @@ malloc_size_of_is_0!(i8, i16, i32, i64, isize);
malloc_size_of_is_0!(f32, f64);

malloc_size_of_is_0!(std::sync::atomic::AtomicBool);
malloc_size_of_is_0!(std::sync::atomic::AtomicIsize, std::sync::atomic::AtomicUsize);

This comment has been minimized.

Copy link
@pyfisch

pyfisch Sep 5, 2018

Author Contributor

Manually formatted, cause it looks better than a multiline macro.

@Manishearth
Copy link
Member

Manishearth commented Sep 5, 2018

@bors-servo r+ rollup

@bors-servo
Copy link
Contributor

bors-servo commented Sep 5, 2018

📌 Commit 5ba4df0 has been approved by Manishearth

@bors-servo
Copy link
Contributor

bors-servo commented Sep 5, 2018

Testing commit 5ba4df0 with merge 4d18014...

bors-servo added a commit that referenced this pull request Sep 5, 2018
Rustfmt malloc_size_of & derive

Part of #21373. Formatting looks good.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21615)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 5, 2018

@bors-servo bors-servo merged commit 5ba4df0 into servo:master Sep 5, 2018
2 of 4 checks passed
2 of 4 checks passed
Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@pyfisch pyfisch deleted the pyfisch:malloc_size_of-fmt branch Sep 5, 2018
@jdm jdm mentioned this pull request Sep 6, 2018
53 of 53 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.