Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFormat component of style_traits #21620
Merged
Conversation
highfive
commented
Sep 5, 2018
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @emilio (or someone else) soon. |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Sep 5, 2018
Format component of style_traits <!-- Please describe your changes on the following line: --> Format `style_traits` with: ``` rustfmt components/style_traits/*.rs ``` --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix part of #21373. - [x] These changes do not require tests because they format the components only. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21620) <!-- Reviewable:end -->
|
|
Could you rearrange the webrender_api crate to be alphabetical? |
bors-servo
added a commit
that referenced
this pull request
Sep 6, 2018
Format component of style_traits <!-- Please describe your changes on the following line: --> Format `style_traits` with: ``` rustfmt components/style_traits/*.rs ``` --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix part of #21373. - [x] These changes do not require tests because they format the components only. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21620) <!-- Reviewable:end -->
|
|
|
@jdm Thanks for the feedback.I re-arranged and re-pushed as below. |
components/style_traits/lib.rs
Outdated
| #[cfg(feature = "servo")] | ||
| #[macro_use] | ||
| extern crate serde; | ||
| #[cfg(feature = "servo")] |
This comment has been minimized.
This comment has been minimized.
jdm
Sep 7, 2018
Member
This cfg(feature = "servo") needs to be moved above webrender_api instead of servo_arc.
|
|
|
@jdm fixed again, sorry. |
|
cc @emilio |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Sep 9, 2018
Format component of style_traits <!-- Please describe your changes on the following line: --> Format `style_traits` with: ``` rustfmt components/style_traits/*.rs ``` --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix part of #21373. - [x] These changes do not require tests because they format the components only. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21620) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Sep 9, 2018
Format component of style_traits <!-- Please describe your changes on the following line: --> Format `style_traits` with: ``` rustfmt components/style_traits/*.rs ``` --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix part of #21373. - [x] These changes do not require tests because they format the components only. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21620) <!-- Reviewable:end -->
|
|
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Sep 15, 2018
This cherry-picks servo/servo#21620.
jankeromnes
pushed a commit
to jankeromnes/gecko
that referenced
this pull request
Sep 16, 2018
This cherry-picks servo/servo#21620.
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 3, 2019
This cherry-picks servo/servo#21620. UltraBlame original commit: d88b4c39dfce50e116436441080dcc9b4acf593e
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 3, 2019
This cherry-picks servo/servo#21620. UltraBlame original commit: d88b4c39dfce50e116436441080dcc9b4acf593e
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 3, 2019
This cherry-picks servo/servo#21620. UltraBlame original commit: d88b4c39dfce50e116436441080dcc9b4acf593e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
chansuke commentedSep 5, 2018
•
edited by jdm
Format
style_traitswith:./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is