Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Sync changes from mozilla-central. #21623

Merged
merged 5 commits into from Sep 5, 2018
Merged

Commits on Sep 5, 2018

  1. style: Make the author styles disabled stuff actually disable style a…

    …ttribute, animations, and XBL rules.
    
    This also removes one of my FIXMEs from when I was looking at this code.
    
    We don't seem to have a pre-existing test for this feature, sigh. I'll try to
    write one if I have cycles for it...
    
    Note that it not applying XBL rules is a feature, given the current state of
    affairs. Video controls and such are right now unusable with no styles enabled.
    
    Differential Revision: https://phabricator.services.mozilla.com/D4795
    emilio committed Sep 5, 2018
  2. style: Add a pref for |clip-path:path()|.

    Add a preference, layout.css.clip-path-path.enabled, for |clip-path:path()|.
    
    Differential Revision: https://phabricator.services.mozilla.com/D4965
    BorisChiou authored and emilio committed Sep 5, 2018
  3. style: Only no-op visited <-> unvisited changes.

    Other changes should really be (and are) indistinguishable.
    
    Differential Revision: https://phabricator.services.mozilla.com/D4847
    emilio committed Sep 5, 2018
  4. style: Use decomposition to interpolate matched perspective transform…

    … operations.
    
    Looks like this produces sensible results for interpolation with 0, though I'm
    not really convinced about the results from, let's say, 1px to 2000px in the
    attached test-case, I would've expected a linear interpolation from that to go
    through normal length interpolation.
    
    css-transforms-1 says:
    
      > Two transform functions with the same name and the same number of arguments
      > are interpolated numerically without a former conversion. The calculated
      > value will be of the same transform function type with the same number of
      > arguments.
      >
      > Special rules apply to <matrix()>.
    
    Which is what we do... I was going to file a spec issue but turns out that it's
    already addressed in css-transforms-2:
    
      https://drafts.csswg.org/css-transforms-2/#interpolation-of-transform-functions
    
    Which says:
    
      > The transform functions <matrix()>, matrix3d() and perspective() get
      > converted into 4x4 matrices first and interpolated as defined in section
      > Interpolation of Matrices afterwards.
    
    Differential Revision: https://phabricator.services.mozilla.com/D4942
    emilio committed Sep 5, 2018
You can’t perform that action at this time.