Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format component of style_derive #21635

Merged
merged 1 commit into from Sep 7, 2018
Merged

Format component of style_derive #21635

merged 1 commit into from Sep 7, 2018

Conversation

@chansuke
Copy link
Contributor

chansuke commented Sep 7, 2018 •
edited by jdm

Format style_derive component by:

rustfmt components/style_derive/*.rs
  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix part of #21373.
  • These changes do not require tests because they format components only.

This change is Reviewable
@chansuke
Format component of style_derive
Loading status checks…
25bc998
@highfive
Copy link

highfive commented Sep 7, 2018

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @ferjm (or someone else) soon.
@jdm
Copy link
Member

jdm commented Sep 7, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Sep 7, 2018

📌 Commit 25bc998 has been approved by jdm
@highfive highfive assigned jdm and unassigned ferjm Sep 7, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Sep 7, 2018

⌛ Testing commit 25bc998 with merge ba8790b...
bors-servo added a commit that referenced this pull request Sep 7, 2018
@bors-servo
Auto merge of #21635 - chansuke:format_style_derive, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ba8790b 
Format component of style_derive

<!-- Please describe your changes on the following line: -->
Format `style_derive` component by:
```
rustfmt components/style_derive/*.rs
```
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix part of #21373.
- [x] These changes do not require tests because they format components only.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21635)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 7, 2018

💔 Test failed - linux-rel-wpt
@jdm
Copy link
Member

jdm commented Sep 7, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Sep 7, 2018

⚡ Previous build results for android, android-x86, arm64, linux-dev, linux-rel-css, mac-dev-unit are reusable. Rebuilding only arm32, linux-rel-wpt, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev...
@bors-servo
Copy link
Contributor

bors-servo commented Sep 7, 2018

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: jdm
Pushing ba8790b to master...
@bors-servo bors-servo merged commit 25bc998 into servo:master Sep 7, 2018
3 of 4 checks passed
3 of 4 checks passed
Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@jdm jdm mentioned this pull request Sep 7, 2018
Closed
53 of 53 tasks complete
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Sep 8, 2018
@chansuke @emilio
Bug 1489667 - Format component of style_derive. r=emilio
0f1a2fb 
This cherry-picks servo/servo#21635
jankeromnes pushed a commit to jankeromnes/gecko that referenced this pull request Sep 8, 2018
@chansuke @emilio
Bug 1489667 - Format component of style_derive. r=emilio
f14e6c1 
This cherry-picks servo/servo#21635
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 3, 2019
@marco-c
Bug 1489667 - Format component of style_derive. r=emilio
269cbff 
This cherry-picks servo/servo#21635

UltraBlame original commit: 9019dae48f5759fa8ad237f7204466b9c32dcef2
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 3, 2019
@marco-c
Bug 1489667 - Format component of style_derive. r=emilio
dcc3a8a 
This cherry-picks servo/servo#21635

UltraBlame original commit: 9019dae48f5759fa8ad237f7204466b9c32dcef2
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 3, 2019
@marco-c
Bug 1489667 - Format component of style_derive. r=emilio
a636363 
This cherry-picks servo/servo#21635

UltraBlame original commit: 9019dae48f5759fa8ad237f7204466b9c32dcef2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@chansuke @highfive @jdm @bors-servo @ferjm
You can’t perform that action at this time.