Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format the rest of gfx #21373 #21638

Merged
merged 2 commits into from Sep 8, 2018
Merged

Format the rest of gfx #21373 #21638

merged 2 commits into from Sep 8, 2018

Conversation

@kingdido999
Copy link
Contributor

kingdido999 commented Sep 8, 2018 •
edited by SimonSapin 

rustfmt $(find components/gfx/tests -type f -name "*.rs")
rustfmt components/gfx/*.rs

This change is Reviewable
kingdido999
Format the rest of gfx #21373
Loading status checks…
3a3c4b8
@jdm jdm mentioned this pull request Sep 8, 2018
Closed
53 of 53 tasks complete
@jdm
Copy link
Member

jdm commented Sep 8, 2018

./mach test-tidy has complaints:

./components/gfx/lib.rs:27: extern crate declaration is not in alphabetical order
	expected: truetype
	found: euclid
./components/gfx/lib.rs:37: extern crate declaration is not in alphabetical order
	expected: servo_allocator
	found: gfx_traits
@jdm
jdm approved these changes Sep 8, 2018
View changes
@jdm jdm added S-fails-tidy and removed S-awaiting-review labels Sep 8, 2018
kingdido999
Reorder gfx lib creates
Loading status checks…
c0da829
@jdm
Copy link
Member

jdm commented Sep 8, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Sep 8, 2018

📌 Commit c0da829 has been approved by jdm
@highfive highfive assigned jdm and unassigned emilio Sep 8, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Sep 8, 2018

⌛ Testing commit c0da829 with merge 5e64578...
bors-servo added a commit that referenced this pull request Sep 8, 2018
@bors-servo
Auto merge of #21638 - kingdido999:master, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5e64578 
Format the rest of gfx #21373

```bash
rustfmt $(find components/gfx/tests -type f -name "*.rs")
rustfmt components/gfx/*.rs
```

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21638)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 8, 2018

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: jdm
Pushing 5e64578 to master...
@bors-servo bors-servo merged commit c0da829 into servo:master Sep 8, 2018
3 of 4 checks passed
3 of 4 checks passed
Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdm jdm

Assignees

@jdm jdm

Labels
S-fails-tidy
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@kingdido999 @jdm @bors-servo @emilio @highfive
You can’t perform that action at this time.