New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hyper to 0.12 #21644

Merged
merged 1 commit into from Nov 1, 2018

Conversation

Projects
None yet
10 participants
@Eijebong
Member

Eijebong commented Sep 8, 2018


This change is Reviewable

@highfive

This comment has been minimized.

highfive commented Sep 8, 2018

Heads up! This PR modifies the following files:

  • @jgraham: components/webdriver_server/Cargo.toml, components/webdriver_server/lib.rs
  • @emilio: components/layout/display_list/webrender_helpers.rs, components/layout/display_list/builder.rs
  • @KiChjang: components/script/dom/request.rs, components/script/dom/servoparser/mod.rs, components/net/lib.rs, components/net/subresource_integrity.rs, components/script/dom/filereader.rs and 37 more
  • @asajeffrey: components/script/dom/request.rs, components/script/dom/servoparser/mod.rs, components/script/dom/filereader.rs, components/script/dom/document.rs, components/script/dom/response.rs and 20 more
  • @cbrewster: components/constellation/lib.rs, components/constellation/Cargo.toml, components/constellation/network_listener.rs
  • @edunham: servo-tidy.toml
  • @paulrouget: components/constellation/lib.rs, components/constellation/Cargo.toml, components/constellation/network_listener.rs
@Eijebong

That's... A lot of leftover debug. I'll fix that

@@ -3,14 +3,17 @@
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
use filemanager_thread::FileManager;
use hyper::header::{Charset, ContentLength, ContentType, Headers};
use hyper::header::{ContentDisposition, DispositionParam, DispositionType};
//use hyper::header::{Charset, ContentLength, ContentType, Headers};

This comment has been minimized.

@Eijebong

Eijebong Sep 8, 2018

Member

Remove that

pub type Connector = HttpsConnector;
impl Stream for WrappedBody {
type Item = <Body as Stream>::Item; // Data ? That would be nice

This comment has been minimized.

@Eijebong

Eijebong Sep 8, 2018

Member

Remove that comment

self.body.poll().map(|res| {
res.map(|maybe_chunk| {
maybe_chunk.map(|chunk| {
trace!("Decoder: chunk: {:?}", chunk);

This comment has been minimized.

@Eijebong

Eijebong Sep 8, 2018

Member

Leftover debug

@@ -180,17 +179,19 @@ fn calculate_response_age(response: &Response) -> Duration {
fn get_response_expiry(response: &Response) -> Duration {
// Calculating Freshness Lifetime <https://tools.ietf.org/html/rfc7234#section-4.2.1>
let age = calculate_response_age(&response);
if let Some(&header::CacheControl(ref directives)) = response.headers.get::<header::CacheControl>() {
debug!("Expiry: Age: {:?}", age);

This comment has been minimized.

@Eijebong

Eijebong Sep 8, 2018

Member

Leftover debug

});
debug!("Expiry: has_no_cache_directive == {}", has_no_cache_directive);

This comment has been minimized.

@Eijebong

Eijebong Sep 8, 2018

Member

Leftover debug

} else {
override_mime.clone()
};
debug!("mime_no_params: {:?}", mime_no_params);

This comment has been minimized.

@Eijebong

Eijebong Sep 8, 2018

Member

Leftover debug

*self.override_charset.borrow_mut() = value.and_then(|value| {
Encoding::for_label(value.as_bytes())
debug!("COUCOU: {:?}", value);

This comment has been minimized.

@Eijebong

Eijebong Sep 8, 2018

Member

Coucou, Leftover debug

@@ -813,6 +879,8 @@ impl XMLHttpRequestMethods for XMLHttpRequest {
return Ok(None);
}
error!("{:?}", self.response_type.get());

This comment has been minimized.

@Eijebong

Eijebong Sep 8, 2018

Member

Leftover debug

@@ -1130,11 +1200,16 @@ impl XMLHttpRequest {
}
let mime_type = self.final_mime_type();
debug!("Final mime type: {:?}", mime_type);

This comment has been minimized.

@Eijebong

Eijebong Sep 8, 2018

Member

Leftover debug

@@ -188,7 +188,8 @@ impl FetchResponseListener for FetchContext {
let _ac = JSAutoCompartment::new(promise_cx, promise.reflector().get_jsobject().get());
match fetch_metadata {
// Step 4.1
Err(_) => {
Err(e) => {
error!("Network error: {:?}", e);

This comment has been minimized.

@Eijebong

Eijebong Sep 8, 2018

Member

Leftover debug

@Eijebong

This comment has been minimized.

Member

Eijebong commented Sep 8, 2018

@bors-servo try

Let's see how much stuff I broke :)

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Sep 8, 2018

⌛️ Trying commit df00a5a with merge bc3c7d4...

bors-servo added a commit that referenced this pull request Sep 8, 2018

Auto merge of #21644 - Eijebong:hyperup, r=<try>
WIP: Update hyper to 0.12

Left to do:
 - Fix the influent::Client call
 - servo/webrender#3034
 - hyperium/mime#91
 - sfackler/typed-headers#3 (still need a lot of work)
 - https://bugzilla.mozilla.org/show_bug.cgi?id=1489792
 - Merge and release the ws stuff (I'll do it once I know everything is ok)
 - Merge and release the influent stuff (Same here, I'll do it once I know everything is ok)
 - #21325
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21644)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Sep 8, 2018

💔 Test failed - linux-dev

@Eijebong

This comment has been minimized.

Member

Eijebong commented Sep 8, 2018

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Sep 8, 2018

⌛️ Trying commit 0859c94 with merge bd23e58...

bors-servo added a commit that referenced this pull request Sep 8, 2018

Auto merge of #21644 - Eijebong:hyperup, r=<try>
WIP: Update hyper to 0.12

Left to do:
 - Fix the influent::Client call
 - servo/webrender#3034
 - hyperium/mime#91
 - sfackler/typed-headers#3 (still need a lot of work)
 - https://bugzilla.mozilla.org/show_bug.cgi?id=1489792
 - Merge and release the ws stuff (I'll do it once I know everything is ok)
 - Merge and release the influent stuff (Same here, I'll do it once I know everything is ok)
 - #21325
 - Fix unit tests
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21644)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Sep 8, 2018

💔 Test failed - linux-dev

@atouchet atouchet referenced this pull request Sep 9, 2018

Closed

Update hyper to 0.12 #19825

@Eijebong

This comment has been minimized.

Member

Eijebong commented Sep 9, 2018

@bors-servo try

Android should be fixed now, cors and url tests too.

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Sep 9, 2018

⌛️ Trying commit 04bd8b1 with merge df1d312...

bors-servo added a commit that referenced this pull request Sep 9, 2018

Auto merge of #21644 - Eijebong:hyperup, r=<try>
WIP: Update hyper to 0.12

Left to do:
 - Fix the influent::Client call
 - servo/webrender#3034
 - hyperium/mime#91
 - sfackler/typed-headers#3 (still need a lot of work)
 - https://bugzilla.mozilla.org/show_bug.cgi?id=1489792
 - Merge and release the ws stuff (I'll do it once I know everything is ok)
 - Merge and release the influent stuff (Same here, I'll do it once I know everything is ok)
 - #21325
 - Fix unit tests
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21644)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Sep 9, 2018

💔 Test failed - mac-dev-unit

@Eijebong

This comment has been minimized.

Member

Eijebong commented Sep 9, 2018

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Sep 9, 2018

⌛️ Trying commit e5c9ebe with merge e00cebd...

bors-servo added a commit that referenced this pull request Sep 9, 2018

Auto merge of #21644 - Eijebong:hyperup, r=<try>
WIP: Update hyper to 0.12

Left to do:
 - Fix the influent::Client call
 - servo/webrender#3034
 - hyperium/mime#91
 - sfackler/typed-headers#3 (still need a lot of work)
 - https://bugzilla.mozilla.org/show_bug.cgi?id=1489792
 - Merge and release the ws stuff (I'll do it once I know everything is ok)
 - Merge and release the influent stuff (Same here, I'll do it once I know everything is ok)
 - #21325
 - Fix unit tests
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21644)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Sep 9, 2018

💔 Test failed - linux-dev

@Eijebong

This comment has been minimized.

Member

Eijebong commented Sep 9, 2018

So one of the failing CSS test has that traceback locally:

 0:09.41 pid:23818 Full command: /home/eijebong/code/servo/target/debug/servo --hard-fail --exit -u Servo/wptrunner -Z disable-text-aa,load-webfonts-synchronously,replace-surrogates --output=/tmp/tmpoy8Cqi/4c3e5077-afa4-43aa-a364-734fd4c33fe2 http://web-platform.test:8000/css/css-transforms/transform-3d-rotateY-stair-above-001.xht --user-stylesheet /home/eijebong/code/servo/resour
ces/ahem.css --resolution 800x600 --certificate-path /tmp/tmpHW1icw/cacert.pem -z
pid:23818 VMware, Inc.
 0:09.41 pid:23818 softpipe
 0:09.41 pid:23818 3.3 (Core Profile) Mesa 18.1.0-devel
 0:12.27 pid:23818 invalid parent! (thread WRRenderBackend#0, at libcore/option.rs:1000)
 0:12.49 pid:23818 stack backtrace:
 0:12.49 pid:23818    0:     0x5615bd94a9b5 - backtrace::backtrace::libunwind::trace::hb918343aa72bb167
 0:12.49 pid:23818                         at /home/eijebong/.cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.2/src/backtrace/libunwind.rs:53
 0:12.49 pid:23818                          - backtrace::backtrace::trace::haf7df220f0adb059                                                                                                                                                                                                                                                                                                  
 0:12.49 pid:23818                         at /home/eijebong/.cargo/registry/src/github.com-1ecc6299db9ec820:12.49 pid:23818    1:     0x5615bd94712e - backtrace::capture::Backtrace::new::h32b02b632a4d2dce
 0:12.49 pid:23818                         at /home/eijebong/.cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.2/src/capture.rs:64
 0:12.49 pid:23818    2:     0x5615b5aa5af9 - servo::main::{{closure}}::ha529a8fcdf792bb5
 0:12.49 pid:23818                         at ports/servo/non_android_main.rs:122
 0:12.49 pid:23818    3:     0x5615bd96cec3 - std::panicking::rust_panic_with_hook::h96bd948766a721a4
 0:12.49 pid:23818                         at libstd/panicking.rs:481
 0:12.49 pid:23818    4:     0x5615bd96ca69 - std::panicking::continue_panic_fmt::h79dd527b10c49814
 0:12.49 pid:23818                         at libstd/panicking.rs:391
 0:12.49 pid:23818    5:     0x5615bd96c965 - rust_begin_unwind
 0:12.49 pid:23818                         at libstd/panicking.rs:326
 0:12.49 pid:23818    6:     0x5615bd9a4dcb - core::panicking::panic_fmt::ha9838fa819cc4c3a
 0:12.49 pid:23818                         at libcore/panicking.rs:77
 0:12.49 pid:23818    7:     0x5615bd999fb1 - core::option::expect_failed::h1c5d07440ac53783
 0:12.49 pid:23818                         at libcore/option.rs:1000
 0:12.49 pid:23818    8:     0x5615bafb645c - <core::option::Option<T>>::expect::h6f5aaa4cc768bfe6
 0:12.49 pid:23818                         at /checkout/src/libcore/option.rs:312
 0:12.49 pid:23818    9:     0x5615bb0e2e32 - webrender::clip_scroll_tree::ClipScrollTree::get_relative_transform::h0c4373107b8b2560
 0:12.49 pid:23818                         at /home/eijebong/.cargo/git/checkouts/webrender-b7aff5a69bd4dc59/c6d9109/webrender/src/clip_scroll_tree.rs:140
 0:12.49 pid:23818   10:     0x5615bb5fbf36 - webrender::prim_store::LocalRectBuilder::set_target_spatial_node::h59ebcd539a1f985c
 0:12.49 pid:23818                         at /home/eijebong/.cargo/git/checkouts/webrender-b7aff5a69bd4dc59/c6d9109/webrender/src/prim_store.rs:164
 0:12.49 pid:23818   11:     0x5615bb6039af - webrender::prim_store::PrimitiveStore::prepare_prim_runs::hfe9e508568748fab
 0:12.49 pid:23818                         at /home/eijebong/.cargo/git/checkouts/webrender-b7aff5a69bd4dc59/c6d9109/webrender/src/prim_store.rs:1814
 0:12.49 pid:23818   12:     0x5615bb602058 - webrender::prim_store::PrimitiveStore::prepare_prim_for_render::hebeda3f61b5e4e99
 0:12.49 pid:23818                         at /home/eijebong/.cargo/git/checkouts/webrender-b7aff5a69bd4dc59/c6d9109/webrender/src/prim_store.rs:1562
 0:12.49 pid:23818   13:     0x5615bb603a38 - webrender::prim_store::PrimitiveStore::prepare_prim_runs::hfe9e508568748fab
 0:12.49 pid:23818                         at /home/eijebong/.cargo/git/checkouts/webrender-b7aff5a69bd4dc59/c6d9109/webrender/src/prim_store.rs:1819
 0:12.49 pid:23818   14:     0x5615bb602058 - webrender::prim_store::PrimitiveStore::prepare_prim_for_render::hebeda3f61b5e4e99
 0:12.49 pid:23818                         at /home/eijebong/.cargo/git/checkouts/webrender-b7aff5a69bd4dc59/c6d9109/webrender/src/prim_store.rs:1562
 0:12.49 pid:23818   15:     0x5615bb603a38 - webrender::prim_store::PrimitiveStore::prepare_prim_runs::hfe9e508568748fab
 0:12.49 pid:23818                         at /home/eijebong/.cargo/git/checkouts/webrender-b7aff5a69bd4dc59/c6d9109/webrender/src/prim_store.rs:1819
 0:12.49 pid:23818   16:     0x5615bb602058 - webrender::prim_store::PrimitiveStore::prepare_prim_for_render::hebeda3f61b5e4e99
 0:12.49 pid:23818                         at /home/eijebong/.cargo/git/checkouts/webrender-b7aff5a69bd4dc59/c6d9109/webrender/src/prim_store.rs:1562
 0:12.49 pid:23818   17:     0x5615bb603a38 - webrender::prim_store::PrimitiveStore::prepare_prim_runs::hfe9e508568748fab
 0:12.49 pid:23818                         at /home/eijebong/.cargo/git/checkouts/webrender-b7aff5a69bd4dc59/c6d9109/webrender/src/prim_store.rs:1819
 0:12.49 pid:23818   18:     0x5615bb1845ae - webrender::frame_builder::FrameBuilder::build_layer_screen_rects_and_cull_layers::h360fc8a1bcd2652f
 0:12.49 pid:23818                         at /home/eijebong/.cargo/git/checkouts/webrender-b7aff5a69bd4dc59/c6d9109/webrender/src/frame_builder.rs:238
 0:12.49 pid:23818   19:     0x5615bb184fc6 - webrender::frame_builder::FrameBuilder::build::h859b35909c41f289
 0:12.49 pid:23818                         at /home/eijebong/.cargo/git/checkouts/webrender-b7aff5a69bd4dc59/c6d9109/webrender/src/frame_builder.rs:334
 0:12.49 pid:23818   20:     0x5615bb1888a3 - webrender::render_backend::Document::render::h4d572fad32658a35
 0:12.49 pid:23818                         at /home/eijebong/.cargo/git/checkouts/webrender-b7aff5a69bd4dc59/c6d9109/webrender/src/render_backend.rs:374
 0:12.49 pid:23818   21:     0x5615bb18faac - webrender::render_backend::RenderBackend::update_document::h84cfa4ef9873b793
 0:12.49 pid:23818                         at /home/eijebong/.cargo/git/checkouts/webrender-b7aff5a69bd4dc59/c6d9109/webrender/src/render_backend.rs:1113
 0:12.49 pid:23818   22:     0x5615bb18df3b - webrender::render_backend::RenderBackend::process_api_msg::h4461a9244bccf23d
 0:12.49 pid:23818                         at /home/eijebong/.cargo/git/checkouts/webrender-b7aff5a69bd4dc59/c6d9109/webrender/src/render_backend.rs:985
 0:12.49 pid:23818   23:     0x5615bb18b798 - webrender::render_backend::RenderBackend::run::h43e303b029f9e960
 0:12.49 pid:23818                         at /home/eijebong/.cargo/git/checkouts/webrender-b7aff5a69bd4dc59/c6d9109/webrender/src/render_backend.rs:795
 0:12.49 pid:23818   24:     0x5615bb1e4741 - webrender::renderer::Renderer::new::{{closure}}::hf13a852b7508c09c
 0:12.49 pid:23818                         at /home/eijebong/.cargo/git/checkouts/webrender-b7aff5a69bd4dc59/c6d9109/webrender/src/renderer.rs:1766
 0:12.50 pid:23818   25:     0x5615bb2a79e4 - std::sys_common::backtrace::__rust_begin_short_backtrace::h0f9125c12669f1f4
 0:12.50 pid:23818                         at /checkout/src/libstd/sys_common/backtrace.rs:136
 0:12.50 pid:23818   26:     0x5615bb0c1c66 - std::thread::Builder::spawn::{{closure}}::{{closure}}::he30209c93d5d6497
 0:12.50 pid:23818                         at /checkout/src/libstd/thread/mod.rs:409
 0:12.50 pid:23818   27:     0x5615bb2497b6 - <std::panic::AssertUnwindSafe<F> as core::ops::function::FnOnce<()>>::call_once::h2f4b77d8171204d1
 0:12.50 pid:23818                         at /checkout/src/libstd/panic.rs:313
 0:12.50 pid:23818   28:     0x5615bb2a9e99 - std::panicking::try::do_call::hb2b05b618e635b7b
 0:12.50 pid:23818                         at /checkout/src/libstd/panicking.rs:310
 0:12.50 pid:23818   29:     0x5615bd996249 - __rust_maybe_catch_panic
 0:12.50 pid:23818                         at libpanic_unwind/lib.rs:103
 0:12.50 pid:23818   30:     0x5615bb2a9120 - std::panicking::try::h2818e6c41b178d2b
 0:12.50 pid:23818                         at /checkout/src/libstd/panicking.rs:289
 0:12.50 pid:23818   31:     0x5615bb2a8bd6 - std::panic::catch_unwind::h510e65e63ec64e31
 0:12.50 pid:23818                         at /checkout/src/libstd/panic.rs:392
 0:12.50 pid:23818   32:     0x5615bb0c163f - std::thread::Builder::spawn::{{closure}}::h0cb58d1069dcb193
 0:12.50 pid:23818                         at /checkout/src/libstd/thread/mod.rs:408
 0:12.50 pid:23818   33:     0x5615bb0c97f5 - <F as alloc::boxed::FnBox<A>>::call_box::hd58dda3c32b1ef77
 0:12.50 pid:23818                         at /checkout/src/liballoc/boxed.rs:646
 0:12.50 pid:23818   34:     0x5615bd985bca - <alloc::boxed::Box<(dyn alloc::boxed::FnBox<A, Output$u3d$R$GT$$u20$$u2b$$u20$$u27$a$RP$$GT$$u20$as$u20$core..ops..function..FnOnce$LT$A$GT$$GT$::call_once::h91e1a0628cdb6b64
 0:12.50 pid:23818                         at /checkout/src/liballoc/boxed.rs:656
 0:12.50 pid:23818                          - std::sys_common::thread::start_thread::h8710783cd11c6158
 0:12.50 pid:23818                         at libstd/sys_common/thread.rs:24
 0:12.50 pid:23818   35:     0x5615bd96d695 - std::sys::unix::thread::Thread::new::thread_start::h8ecb5f3a76b46e8e
 0:12.50 pid:23818                         at libstd/sys/unix/thread.rs:90
 0:12.50 pid:23818   36:     0x7fd868473a9c - start_thread
 0:12.50 pid:23818   37:     0x7fd867461a42 - clone
 0:12.50 pid:23818   38:                0x0 - <unknown>
 0:12.50 pid:23818 ERROR 2018-09-09T03:24:52Z: servo: invalid parent!

@glennw @kvark any idea ?

@highfive highfive removed the S-tests-failed label Sep 9, 2018

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 1, 2018

⌛️ Testing commit c1a8b64 with merge 37bc17b...

bors-servo added a commit that referenced this pull request Nov 1, 2018

Auto merge of #21644 - Eijebong:hyperup, r=jdm
Update hyper to 0.12

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21644)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 1, 2018

💔 Test failed - linux-rel-wpt

@Eijebong

This comment has been minimized.

Member

Eijebong commented Nov 1, 2018

@bors-servo try=wpt

Turns out having duplicate sections in ini files is bad... Who would have thought. Let's see if I fixed it

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 1, 2018

⌛️ Trying commit 024b40b with merge e9573e6...

bors-servo added a commit that referenced this pull request Nov 1, 2018

Auto merge of #21644 - Eijebong:hyperup, r=<try>
Update hyper to 0.12

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21644)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 1, 2018

☀️ Test successful - linux-rel-css, linux-rel-wpt
State: approved= try=True

@Eijebong

This comment has been minimized.

Member

Eijebong commented Nov 1, 2018

@bors-servo r=jdm

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 1, 2018

📌 Commit 024b40b has been approved by jdm

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 1, 2018

⌛️ Testing commit 024b40b with merge 46fdf15...

bors-servo added a commit that referenced this pull request Nov 1, 2018

Auto merge of #21644 - Eijebong:hyperup, r=jdm
Update hyper to 0.12

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21644)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 1, 2018

@bors-servo bors-servo merged commit 024b40b into servo:master Nov 1, 2018

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details

mykmelez pushed a commit to mozilla/gecko that referenced this pull request Nov 5, 2018

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Nov 5, 2018

@paulrouget

This comment has been minimized.

Contributor

paulrouget commented Nov 6, 2018

This broke Android: #22114

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment