New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix space leak when pipeline is closed #21647

Merged
merged 1 commit into from Sep 20, 2018

Conversation

Projects
None yet
7 participants
@AgustinCB
Contributor

AgustinCB commented Sep 8, 2018

Add a new control message to drop remove worklets.

Implement Drop for Worklet and get the worklet thread pool. Use that
pool to send ExitWorklet to all the threads with the id of the
Worklet that it's dropping.


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #17442
  • There are tests for these changes OR
  • These changes do not require tests because I don't know how to add a test for this :(

If you consider this needs a test, could you point me out on how to write (and run!) one in this project? I gave this a couple tries, but I wasn't very successful.


This change is Reviewable

Fix space leak when pipeline is closed
Add a new control message to drop remove worklets.

Implement `Drop` for `Worklet` and get the worklet thread pool. Use that
pool to send `ExitWorklet` to all the threads with the id of the
`Worklet` that it's dropping.
@highfive

This comment has been minimized.

highfive commented Sep 8, 2018

Heads up! This PR modifies the following files:

@highfive

This comment has been minimized.

highfive commented Sep 8, 2018

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@jdm

This comment has been minimized.

Member

jdm commented Sep 10, 2018

r? asajeffrey

@highfive highfive assigned asajeffrey and unassigned emilio Sep 10, 2018

@gterzian

This comment has been minimized.

Collaborator

gterzian commented Sep 20, 2018

@asajeffrey Looks like this one is awaiting review :)

@asajeffrey

This comment has been minimized.

Member

asajeffrey commented Sep 20, 2018

Oops, missed this one! I'll have a look.

@asajeffrey

This comment has been minimized.

Member

asajeffrey commented Sep 20, 2018

This looks really good, yay! @bors-servo r+

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Sep 20, 2018

📌 Commit b3e8547 has been approved by asajeffrey

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Sep 20, 2018

⌛️ Testing commit b3e8547 with merge ae40a33...

bors-servo added a commit that referenced this pull request Sep 20, 2018

Auto merge of #21647 - AgustinCB:fix-space-leak-when-pipeline-is-clos…
…ed, r=asajeffrey

Fix space leak when pipeline is closed

Add a new control message to drop remove worklets.

Implement `Drop` for `Worklet` and get the worklet thread pool. Use that
pool to send `ExitWorklet` to all the threads with the id of the
`Worklet` that it's dropping.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #17442
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because I don't know how to add a test for this :(

If you consider this needs a test, could you point me out on how to write (and run!) one in this project? I gave this a couple tries, but I wasn't very successful.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21647)
<!-- Reviewable:end -->
@jdm

This comment has been minimized.

Member

jdm commented Sep 20, 2018

@bors-servo retry

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Sep 20, 2018

⌛️ Testing commit b3e8547 with merge 302e2cf...

bors-servo added a commit that referenced this pull request Sep 20, 2018

Auto merge of #21647 - AgustinCB:fix-space-leak-when-pipeline-is-clos…
…ed, r=asajeffrey

Fix space leak when pipeline is closed

Add a new control message to drop remove worklets.

Implement `Drop` for `Worklet` and get the worklet thread pool. Use that
pool to send `ExitWorklet` to all the threads with the id of the
`Worklet` that it's dropping.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #17442
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because I don't know how to add a test for this :(

If you consider this needs a test, could you point me out on how to write (and run!) one in this project? I gave this a couple tries, but I wasn't very successful.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21647)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Sep 20, 2018

@bors-servo bors-servo merged commit b3e8547 into servo:master Sep 20, 2018

3 of 4 checks passed

Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment