Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

format components/profile #21651

Merged
merged 1 commit into from Sep 10, 2018
Merged

format components/profile #21651

merged 1 commit into from Sep 10, 2018

Conversation

@AnshulMalik
Copy link
Contributor

AnshulMalik commented Sep 9, 2018 •
edited by SimonSapin

Issue #21373

This change is Reviewable
@highfive
Copy link

highfive commented Sep 9, 2018

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @paulrouget (or someone else) soon.
@highfive
Copy link

highfive commented Sep 9, 2018

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
@CYBAI
Copy link
Collaborator

CYBAI commented Sep 9, 2018

Maybe you'd like to run ./mach test-tidy

$ ./mach test-tidy --no-progress --all
 0:16.64 INFO Diffing old and new manifests /home/travis/build/servo/servo/tests/wpt/mozilla/meta/MANIFEST.json
 0:16.82 INFO Diffing old and new manifests /home/travis/build/servo/servo/tests/wpt/metadata/MANIFEST.json
 0:22.23 INFO Diffing old and new manifests /home/travis/build/servo/servo/tests/wpt/webgl/meta/MANIFEST.json
Checking the config file...
Checking the wpt manifest file...
Checking directories for correct file extensions...
Running the WPT lint on ./tests/wpt/web-platform-tests/...
Running the WPT lint on ./tests/wpt/mozilla/tests/...
Checking files for tidiness...
./components/profile/time.rs:268: Line is longer than 120 characters
Running the dependency licensing lint...
The command "./mach test-tidy --no-progress --all" exited with 1.
@AnshulMalik
format components/profile - #21373
Loading status checks…
72748de
@AnshulMalik AnshulMalik force-pushed the AnshulMalik:format-profile branch from 9ce6d93 to 72748de Sep 9, 2018
@jdm jdm mentioned this pull request Sep 9, 2018
Closed
53 of 53 tasks complete
@jdm
Copy link
Member

jdm commented Sep 10, 2018

@bors-servo r+
Thanks!
@bors-servo
Copy link
Contributor

bors-servo commented Sep 10, 2018

📌 Commit 72748de has been approved by jdm
@highfive highfive assigned jdm and unassigned paulrouget Sep 10, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Sep 10, 2018

⌛ Testing commit 72748de with merge 2f0162b...
bors-servo added a commit that referenced this pull request Sep 10, 2018
@bors-servo
Auto merge of #21651 - AnshulMalik:format-profile, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
2f0162b 
format components/profile

Issue #21373

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21651)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 10, 2018

💔 Test failed - linux-rel-wpt
@jdm
Copy link
Member

jdm commented Sep 10, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Sep 10, 2018

⌛ Testing commit 72748de with merge e122341...
bors-servo added a commit that referenced this pull request Sep 10, 2018
@bors-servo
Auto merge of #21651 - AnshulMalik:format-profile, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e122341 
format components/profile

Issue #21373

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21651)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 10, 2018

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: jdm
Pushing e122341 to master...
@bors-servo bors-servo merged commit 72748de into servo:master Sep 10, 2018
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@AnshulMalik AnshulMalik deleted the AnshulMalik:format-profile branch Sep 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@AnshulMalik @highfive @CYBAI @jdm @bors-servo @paulrouget
You can’t perform that action at this time.