Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format component `style` #21652

Merged
merged 4 commits into from Sep 9, 2018
Merged

Format component `style` #21652

merged 4 commits into from Sep 9, 2018

Conversation

@chansuke
Copy link
Contributor

chansuke commented Sep 9, 2018 •
edited by emilio

Format components/style with:

rustfmt components/style/*.rs
  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix part of #21373.
  • These changes do not require tests because they format the components only.

This change is Reviewable
@highfive
Copy link

highfive commented Sep 9, 2018

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @SimonSapin (or someone else) soon.
@highfive
Copy link

highfive commented Sep 9, 2018

Heads up! This PR modifies the following files:

  • @emilio: components/style/values/generics/flex.rs, components/style/stylesheet_set.rs, components/style/dom_apis.rs, components/style/gecko/url.rs, components/style/invalidation/element/element_wrapper.rs and 114 more
@highfive
Copy link

highfive commented Sep 9, 2018

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style code, but no tests are modified. Please consider adding a test!
@CYBAI
Copy link
Collaborator

CYBAI commented Sep 9, 2018

Maybe These changes fix #21373. needs to be These changes fix part of #21373.?
Or, it will make the issue closed once this PR merged.
BorisChiou added 3 commits Sep 7, 2018
@BorisChiou @emilio
style: Make SVGPathData and clip-path: path() animatable.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
14911b9 
Implement Animate trait for SVGPathData.

The basic idea is: we normalize |this| and |other| svg paths, and then
do interpolation on the normalized svg paths. The normalization is to
convert relative coordinates into absolute coordinates, so we could do
real number interpolation on each path command directly.

In this patch, we also make |clip-path:path()| animatable.

Differential Revision: https://phabricator.services.mozilla.com/D4786
@BorisChiou @emilio
style: Make offset-path: path() animatable.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
b0604c9 
Here, we change the animation type of offset-path as ComputedValue, so
we could do animation on it. Also enable the wpt for offset-path
interpolation. In test_transition_per_property.html, we add some basic tests
ifor offset-path.

ToAnimatedZero for PathCommand will be dropped later.

Because the animations of arcs with mismatched flags are fallen back to
discrete animations, the result of getComputedValue is not normalized in this
case. This makes some wpt failed even though the progress is 100%.

Depends on D4786

Differential Revision: https://phabricator.services.mozilla.com/D4787
@BorisChiou @emilio
style: Use the standalone struct and enum for the flags in SVG path.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
Loading status checks…
31fc6cd 
We define the standalone types for using derive macro easily and overriding
the behaviors of this traits. This could avoid defining the general
behavior of booleans.

Depends on D4788

Differential Revision: https://phabricator.services.mozilla.com/D4813
@jdm
Copy link
Member

jdm commented Sep 9, 2018

cc @emilio
@emilio
Copy link
Member

emilio commented Sep 9, 2018

LGTM, I'll rebase this on top of #21653 because they'd conflict.
@emilio
Copy link
Member

emilio commented Sep 9, 2018

I filed rust-lang/rustfmt#3005 on some awkward formatting.
@chansuke @emilio
Format style component.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
Loading status checks…
8dab4d6
@emilio emilio force-pushed the chansuke:format_style branch from 2e49886 to 8dab4d6 Sep 9, 2018
@emilio
Copy link
Member

emilio commented Sep 9, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Sep 9, 2018

📌 Commit 8dab4d6 has been approved by emilio
@highfive highfive assigned emilio and unassigned SimonSapin Sep 9, 2018
@emilio
Copy link
Member

emilio commented Sep 9, 2018

https://bugzilla.mozilla.org/show_bug.cgi?id=1489862
@jdm jdm mentioned this pull request Sep 9, 2018
Closed
53 of 53 tasks complete
@emilio
Copy link
Member

emilio commented Sep 9, 2018

@bors-servo p=1

  • So that they both merge before other changes to components/ which are also in the queue and should get synced in Gecko, so that the order of the commit is the same on both repos... Though it's fairly unimportant if it doesn't happen.
@bors-servo
Copy link
Contributor

bors-servo commented Sep 9, 2018

⌛ Testing commit 8dab4d6 with merge c16d77f...
bors-servo added a commit that referenced this pull request Sep 9, 2018
@bors-servo
Auto merge of #21652 - chansuke:format_style, r=emilio
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c16d77f 
Format component `style`

<!-- Please describe your changes on the following line: -->
Format `components/style` with:
```
rustfmt components/style/*.rs
```

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix part of #21373.
- [x] These changes do not require tests because they format the components only.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21652)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 9, 2018

💔 Test failed - mac-rel-wpt3
@jdm
Copy link
Member

jdm commented Sep 9, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Sep 9, 2018

⌛ Testing commit 8dab4d6 with merge c8fd638...
bors-servo added a commit that referenced this pull request Sep 9, 2018
@bors-servo
Auto merge of #21652 - chansuke:format_style, r=emilio
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c8fd638 
Format component `style`

<!-- Please describe your changes on the following line: -->
Format `components/style` with:
```
rustfmt components/style/*.rs
```

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix part of #21373.
- [x] These changes do not require tests because they format the components only.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21652)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 9, 2018

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: emilio
Pushing c8fd638 to master...
@bors-servo bors-servo merged commit 8dab4d6 into servo:master Sep 9, 2018
3 of 4 checks passed
3 of 4 checks passed
Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Sep 9, 2018
@chansuke @emilio
Bug 1489862 - Format style component. r=emilio
4109731 
This cherry-picks servo/servo#21652.
jankeromnes pushed a commit to jankeromnes/gecko that referenced this pull request Sep 10, 2018
@chansuke @emilio
Bug 1489862 - Format style component. r=emilio
e0212e9 
This cherry-picks servo/servo#21652.
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 3, 2019
@marco-c
Bug 1489862 - Format style component. r=emilio
fef2abc 
This cherry-picks servo/servo#21652.

UltraBlame original commit: 9070b703aadf916ba787296f3a41c04752368db2
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 3, 2019
@marco-c
Bug 1489862 - Format style component. r=emilio
1fc5d0b 
This cherry-picks servo/servo#21652.

UltraBlame original commit: 9070b703aadf916ba787296f3a41c04752368db2
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 3, 2019
@marco-c
Bug 1489862 - Format style component. r=emilio
9073c6b 
This cherry-picks servo/servo#21652.

UltraBlame original commit: 9070b703aadf916ba787296f3a41c04752368db2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants
@chansuke @highfive @CYBAI @jdm @emilio @bors-servo @SimonSapin @BorisChiou
You can’t perform that action at this time.