Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: sync changes from mozilla-central. #21653

Merged
merged 3 commits into from Sep 9, 2018
Merged

Commits on Sep 9, 2018

  1. style: Make SVGPathData and clip-path: path() animatable.

    Implement Animate trait for SVGPathData.
    
    The basic idea is: we normalize |this| and |other| svg paths, and then
    do interpolation on the normalized svg paths. The normalization is to
    convert relative coordinates into absolute coordinates, so we could do
    real number interpolation on each path command directly.
    
    In this patch, we also make |clip-path:path()| animatable.
    
    Differential Revision: https://phabricator.services.mozilla.com/D4786
    BorisChiou authored and emilio committed Sep 9, 2018
  2. style: Make offset-path: path() animatable.

    Here, we change the animation type of offset-path as ComputedValue, so
    we could do animation on it. Also enable the wpt for offset-path
    interpolation. In test_transition_per_property.html, we add some basic tests
    ifor offset-path.
    
    ToAnimatedZero for PathCommand will be dropped later.
    
    Because the animations of arcs with mismatched flags are fallen back to
    discrete animations, the result of getComputedValue is not normalized in this
    case. This makes some wpt failed even though the progress is 100%.
    
    Depends on D4786
    
    Differential Revision: https://phabricator.services.mozilla.com/D4787
    BorisChiou authored and emilio committed Sep 9, 2018
  3. style: Use the standalone struct and enum for the flags in SVG path.

    We define the standalone types for using derive macro easily and overriding
    the behaviors of this traits. This could avoid defining the general
    behavior of booleans.
    
    Depends on D4788
    
    Differential Revision: https://phabricator.services.mozilla.com/D4813
    BorisChiou authored and emilio committed Sep 9, 2018
You can’t perform that action at this time.