Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

format components/profile_traits #21657

Merged
merged 1 commit into from Sep 10, 2018
Merged

format components/profile_traits #21657

merged 1 commit into from Sep 10, 2018

Conversation

@AnshulMalik
Copy link
Contributor

AnshulMalik commented Sep 10, 2018 •
edited by SimonSapin

Issue: #21373

This change is Reviewable
@AnshulMalik
format components/profile_traits
Loading status checks…
ce9231c
@highfive
Copy link

highfive commented Sep 10, 2018

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @jdm (or someone else) soon.
@highfive
Copy link

highfive commented Sep 10, 2018

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
@jdm jdm mentioned this pull request Sep 10, 2018
Closed
53 of 53 tasks complete
@jdm
Copy link
Member

jdm commented Sep 10, 2018

@bors-servo r+
Thank you!
@bors-servo
Copy link
Contributor

bors-servo commented Sep 10, 2018

📌 Commit ce9231c has been approved by jdm
@nox
Copy link
Member

nox commented Sep 10, 2018

@bors-servo rollup
@bors-servo
Copy link
Contributor

bors-servo commented Sep 10, 2018

⌛ Testing commit ce9231c with merge 6cad3f4...
bors-servo added a commit that referenced this pull request Sep 10, 2018
@bors-servo
Auto merge of #21657 - AnshulMalik:format-profile_traits, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6cad3f4 
format components/profile_traits

Issue: #21373

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21657)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 10, 2018

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: jdm
Pushing 6cad3f4 to master...
@bors-servo bors-servo merged commit ce9231c into servo:master Sep 10, 2018
3 of 4 checks passed
3 of 4 checks passed
Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@AnshulMalik AnshulMalik deleted the AnshulMalik:format-profile_traits branch Sep 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@AnshulMalik @highfive @jdm @bors-servo @nox
You can’t perform that action at this time.