Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some more drive-by fixes for rgba8_image_to_tex_image_data #21660

Merged
merged 3 commits into from Sep 11, 2018
Merged

Some more drive-by fixes for rgba8_image_to_tex_image_data #21660

merged 3 commits into from Sep 11, 2018
+18 −29

Conversation

@nox
Copy link
Member

nox commented Sep 10, 2018 •
edited by SimonSapin

This change is Reviewable
nox added 2 commits Sep 10, 2018
@nox
Fix the remaining LUMINANCE* cases in rgba8_image_to_tex_image_data
7e74417
@nox
Reuse input vector for LUMINANCE_ALPHA/HALF_FLOAT
e1486f7
@highfive
Copy link

highfive commented Sep 10, 2018

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webglrenderingcontext.rs
  • @KiChjang: components/script/dom/webglrenderingcontext.rs
@highfive
Copy link

highfive commented Sep 10, 2018

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@jdm
Copy link
Member

jdm commented Sep 10, 2018

Build errors.
@nox
Reuse input buffer for RGB/UNSIGNED_BYTE in rgba8_image_to_tex_image_…
Loading status checks…
dac7740 
…data
@nox nox force-pushed the webgl branch from d4466ca to dac7740 Sep 10, 2018
@nox
Copy link
Member Author

nox commented Sep 10, 2018

Fixed.
@jdm
Copy link
Member

jdm commented Sep 10, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Sep 10, 2018

📌 Commit dac7740 has been approved by jdm
@highfive highfive assigned jdm and unassigned Manishearth Sep 10, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Sep 10, 2018

⌛ Testing commit dac7740 with merge 5c52770...
bors-servo added a commit that referenced this pull request Sep 10, 2018
@bors-servo
Auto merge of #21660 - servo:webgl, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5c52770 
Some more drive-by fixes for rgba8_image_to_tex_image_data

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21660)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 10, 2018

💔 Test failed - linux-rel-css
@jdm
Copy link
Member

jdm commented Sep 10, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Sep 10, 2018

⌛ Testing commit dac7740 with merge 9ea9085...
bors-servo added a commit that referenced this pull request Sep 10, 2018
@bors-servo
Auto merge of #21660 - servo:webgl, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9ea9085 
Some more drive-by fixes for rgba8_image_to_tex_image_data

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21660)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 10, 2018

💔 Test failed - linux-rel-wpt
@jdm
Copy link
Member

jdm commented Sep 10, 2018

@bors-servo retry

  • oom
@bors-servo
Copy link
Contributor

bors-servo commented Sep 10, 2018

⌛ Testing commit dac7740 with merge edee784...
bors-servo added a commit that referenced this pull request Sep 10, 2018
@bors-servo
Auto merge of #21660 - servo:webgl, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
edee784 
Some more drive-by fixes for rgba8_image_to_tex_image_data

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21660)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 10, 2018

💔 Test failed - mac-rel-wpt3
@jdm
Copy link
Member

jdm commented Sep 10, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Sep 10, 2018

⌛ Testing commit dac7740 with merge b0ee750...
bors-servo added a commit that referenced this pull request Sep 10, 2018
@bors-servo
Auto merge of #21660 - servo:webgl, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b0ee750 
Some more drive-by fixes for rgba8_image_to_tex_image_data

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21660)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 11, 2018

💔 Test failed - linux-rel-css
@jdm
Copy link
Member

jdm commented Sep 11, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Sep 11, 2018

⚡ Previous build results for android, android-x86, arm32, arm64, linux-dev, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt2, mac-rel-wpt3, windows-msvc-dev are reusable. Rebuilding only linux-rel-css, mac-rel-wpt1, mac-rel-wpt4...
@bors-servo
Copy link
Contributor

bors-servo commented Sep 11, 2018

💔 Test failed - linux-rel-css
@jdm
Copy link
Member

jdm commented Sep 11, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Sep 11, 2018

⚡ Previous build results for android, android-x86, arm32, arm64, linux-dev, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only linux-rel-css...
@bors-servo
Copy link
Contributor

bors-servo commented Sep 11, 2018

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: jdm
Pushing b0ee750 to master...
@bors-servo bors-servo merged commit dac7740 into master Sep 11, 2018
3 of 4 checks passed
3 of 4 checks passed
Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@nox @highfive @jdm @bors-servo @Manishearth
You can’t perform that action at this time.