Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format component size_of_test #21661

Merged
merged 1 commit into from Sep 10, 2018
Merged

Format component size_of_test #21661

merged 1 commit into from Sep 10, 2018

Conversation

@chansuke
Copy link
Contributor

chansuke commented Sep 10, 2018 •
edited by jdm

Format components/size_of_test by:

rustfmt components/size_of_test/*.rs
  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix part of #21373.
  • These changes do not require tests because they format code only.

This change is Reviewable
@chansuke
Format component size_of_test
Loading status checks…
52a11d8
@highfive
Copy link

highfive commented Sep 10, 2018

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @SimonSapin (or someone else) soon.
@jdm
Copy link
Member

jdm commented Sep 10, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Sep 10, 2018

📌 Commit 52a11d8 has been approved by jdm
@highfive highfive assigned jdm and unassigned SimonSapin Sep 10, 2018
@jdm jdm mentioned this pull request Sep 10, 2018
Closed
53 of 53 tasks complete
@nox
Copy link
Member

nox commented Sep 10, 2018

@bors-servo rollup
@bors-servo
Copy link
Contributor

bors-servo commented Sep 10, 2018

⌛ Testing commit 52a11d8 with merge 795e7f6...
bors-servo added a commit that referenced this pull request Sep 10, 2018
@bors-servo
Auto merge of #21661 - chansuke:format_size_of_test, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
795e7f6 
Format component size_of_test

<!-- Please describe your changes on the following line: -->
Format `components/size_of_test` by:
```
rustfmt components/size_of_test/*.rs
```
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix part of #21373.
- [x] These changes do not require tests because they format code only.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21661)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 10, 2018

💔 Test failed - linux-rel-css
@jdm
Copy link
Member

jdm commented Sep 10, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Sep 10, 2018

⚡ Previous build results for android, android-x86, arm32, arm64, linux-dev, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only linux-rel-css...
@bors-servo
Copy link
Contributor

bors-servo commented Sep 10, 2018

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: jdm
Pushing 795e7f6 to master...
@bors-servo bors-servo merged commit 52a11d8 into servo:master Sep 10, 2018
3 of 4 checks passed
3 of 4 checks passed
Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Sep 15, 2018
@chansuke @emilio
Bug 1491577 - Format component size_of_test. r=emilio
79427e9 
This cherry-picks servo/servo#21661.
jankeromnes pushed a commit to jankeromnes/gecko that referenced this pull request Sep 16, 2018
@chansuke @emilio
Bug 1491577 - Format component size_of_test. r=emilio
39d1d3b 
This cherry-picks servo/servo#21661.
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 3, 2019
@marco-c
Bug 1491577 - Format component size_of_test. r=emilio
4bf2460 
This cherry-picks servo/servo#21661.

UltraBlame original commit: 07329b12c5aac3c6a8ff2bd303095c866335cea0
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 3, 2019
@marco-c
Bug 1491577 - Format component size_of_test. r=emilio
b09559b 
This cherry-picks servo/servo#21661.

UltraBlame original commit: 07329b12c5aac3c6a8ff2bd303095c866335cea0
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 3, 2019
@marco-c
Bug 1491577 - Format component size_of_test. r=emilio
2d9fbe5 
This cherry-picks servo/servo#21661.

UltraBlame original commit: 07329b12c5aac3c6a8ff2bd303095c866335cea0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@chansuke @highfive @jdm @bors-servo @nox @SimonSapin
You can’t perform that action at this time.