Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format ports/servo #21676

Merged
merged 1 commit into from Sep 12, 2018
Merged

Format ports/servo #21676

merged 1 commit into from Sep 12, 2018

Conversation

@chansuke
Copy link
Contributor

chansuke commented Sep 11, 2018 •
edited by jdm

Format ports/servo with:

rustfmt ports/servo/*.rs

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix part of #23137.
  • These changes do not require tests because they format the code only.

This change is Reviewable
@chansuke
Format ports/servo
Loading status checks…
bde84ae
@highfive
Copy link

highfive commented Sep 11, 2018

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon.
@highfive
Copy link

highfive commented Sep 11, 2018

Heads up! This PR modifies the following files:

  • @paulrouget: ports/servo/glutin_app/keyutils.rs, ports/servo/browser.rs, ports/servo/platform/macos/mod.rs, ports/servo/glutin_app/window.rs, ports/servo/non_android_main.rs and 1 more
@highfive
Copy link

highfive commented Sep 11, 2018

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
@jdm jdm mentioned this pull request Sep 11, 2018
Closed
53 of 53 tasks complete
@jdm
Copy link
Member

jdm commented Sep 11, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Sep 11, 2018

📌 Commit bde84ae has been approved by jdm
@highfive highfive assigned jdm and unassigned Manishearth Sep 11, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Sep 12, 2018

⌛ Testing commit bde84ae with merge 030d797...
bors-servo added a commit that referenced this pull request Sep 12, 2018
@bors-servo
Auto merge of #21676 - chansuke:format_ports_servo, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
030d797 
Format ports/servo

<!-- Please describe your changes on the following line: -->
Format `ports/servo` with:

`rustfmt ports/servo/*.rs`

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix part of #23137.
- [x] These changes do not require tests because they format the code only.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21676)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 12, 2018

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: jdm
Pushing 030d797 to master...
@bors-servo bors-servo merged commit bde84ae into servo:master Sep 12, 2018
2 of 4 checks passed
2 of 4 checks passed
Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Sep 12, 2018
Closed
1 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@chansuke @highfive @jdm @bors-servo @Manishearth
You can’t perform that action at this time.