Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upsend pageErrors to devtools console #21678
Closed
Conversation
highfive
commented
Sep 11, 2018
|
Heads up! This PR modifies the following files:
|
highfive
commented
Sep 11, 2018
|
|
|
I'm sorry that this was ignored for so long - this looks like a good improvement! |
| @@ -377,10 +376,34 @@ impl GlobalScope { | |||
|
|
|||
| // Step 9. | |||
| if event_status == EventStatus::NotCanceled { | |||
| if let Some(chan) = self.devtools_chan() { | |||
This comment has been minimized.
This comment has been minimized.
jdm
Oct 31, 2018
Member
We should only report the error to the devtools if we don't forward it to a worker object in the code that follows this block.
| timeStamp: 0, | ||
| error: false, | ||
| warning: false, | ||
| exception: false, |
This comment has been minimized.
This comment has been minimized.
| @@ -83,6 +83,7 @@ pub enum ScriptToDevtoolsControlMsg { | |||
| ), | |||
| /// A particular page has invoked the console API. | |||
| ConsoleAPI(PipelineId, ConsoleMessage, Option<WorkerId>), | |||
| PageErrorAPI(PipelineId, PageErrorAPI, Option<WorkerId>), | |||
This comment has been minimized.
This comment has been minimized.
jdm
Oct 31, 2018
Member
Add /// An unhandled exception has occurred in a particular page. Also I think PageError is more clear; the previous message is ConsoleAPI because it is a message for the methods of the Console API.
| @@ -285,6 +294,37 @@ fn run_server( | |||
| actors.register(Box::new(thread)); | |||
| } | |||
|
|
|||
| fn handle_console_page_error_message( | |||
This comment has been minimized.
This comment has been minimized.
|
|
|
I'll come back later :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
AnshulMalik commentedSep 11, 2018
•
edited
Fixes : #13161
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsHandle pageErrors differently than normal console messages, since these contains stacktrace, which will be supported soon.
This change is