Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

format script_layout_interface #21687

Merged
merged 1 commit into from Sep 13, 2018
Merged

format script_layout_interface #21687

merged 1 commit into from Sep 13, 2018

Conversation

@AnshulMalik
Copy link
Contributor

AnshulMalik commented Sep 12, 2018 •
edited

  • ./mach test-tidy does not report any errors

This change is Reviewable
@AnshulMalik
format script_layout_interface
Loading status checks…
ae469b0
@highfive
Copy link

highfive commented Sep 12, 2018

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
@jdm jdm mentioned this pull request Sep 12, 2018
Closed
53 of 53 tasks complete
@jdm
Copy link
Member

jdm commented Sep 12, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Sep 12, 2018

📌 Commit ae469b0 has been approved by jdm
@highfive highfive assigned jdm and unassigned paulrouget Sep 12, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Sep 13, 2018

⌛ Testing commit ae469b0 with merge 5a22043...
bors-servo added a commit that referenced this pull request Sep 13, 2018
@bors-servo
Auto merge of #21687 - AnshulMalik:format-script_layout, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5a22043 
format script_layout_interface

- [x] `./mach test-tidy` does not report any errors

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21687)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 13, 2018

💔 Test failed - linux-rel-wpt
@jdm
Copy link
Member

jdm commented Sep 13, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Sep 13, 2018

⌛ Testing commit ae469b0 with merge ea697c5...
bors-servo added a commit that referenced this pull request Sep 13, 2018
@bors-servo
Auto merge of #21687 - AnshulMalik:format-script_layout, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ea697c5 
format script_layout_interface

- [x] `./mach test-tidy` does not report any errors

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21687)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 13, 2018

💔 Test failed - linux-rel-wpt
@jdm
Copy link
Member

jdm commented Sep 13, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Sep 13, 2018

⌛ Testing commit ae469b0 with merge efa2c73...
bors-servo added a commit that referenced this pull request Sep 13, 2018
@bors-servo
Auto merge of #21687 - AnshulMalik:format-script_layout, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
efa2c73 
format script_layout_interface

- [x] `./mach test-tidy` does not report any errors

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21687)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 13, 2018

💔 Test failed - mac-rel-wpt4
@nox nox mentioned this pull request Sep 13, 2018
Merged
4 of 4 tasks complete
@nox
Copy link
Member

nox commented Sep 13, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Sep 13, 2018

⚡ Previous build results for android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, windows-msvc-dev are reusable. Rebuilding only mac-rel-wpt4...
@bors-servo
Copy link
Contributor

bors-servo commented Sep 13, 2018

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: jdm
Pushing efa2c73 to master...
@bors-servo bors-servo merged commit ae469b0 into servo:master Sep 13, 2018
3 of 4 checks passed
3 of 4 checks passed
Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@AnshulMalik @highfive @jdm @bors-servo @nox @paulrouget
You can’t perform that action at this time.