Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows nightly upload job #21700

Merged
merged 1 commit into from Sep 13, 2018
Merged

Fix Windows nightly upload job #21700

merged 1 commit into from Sep 13, 2018

Conversation

@ferjm
Copy link
Member

ferjm commented Sep 13, 2018 •
edited by SimonSapin

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #21699

This change is Reviewable
@ferjm
Amend name of Windows nightly installer
Loading status checks…
a8c8392
@highfive
Copy link

highfive commented Sep 13, 2018

Heads up! This PR modifies the following files:
@ferjm ferjm mentioned this pull request Sep 13, 2018
Closed
@ferjm
Copy link
Member Author

ferjm commented Sep 13, 2018

r? @jdm
@highfive highfive assigned jdm and unassigned Manishearth Sep 13, 2018
@Manishearth
Copy link
Member

Manishearth commented Sep 13, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Sep 13, 2018

📌 Commit a8c8392 has been approved by Manishearth
@highfive highfive assigned Manishearth and unassigned jdm Sep 13, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Sep 13, 2018

⌛ Testing commit a8c8392 with merge 5620a49...
bors-servo added a commit that referenced this pull request Sep 13, 2018
@bors-servo
Auto merge of #21700 - ferjm:windows.msvc.nightly.upload, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5620a49 
Fix Windows nightly upload job

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #21699

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21700)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 13, 2018

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: Manishearth
Pushing 5620a49 to master...
@bors-servo bors-servo merged commit a8c8392 into servo:master Sep 13, 2018
2 of 4 checks passed
2 of 4 checks passed
Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Windows nightly upload job is broken
5 participants
@ferjm @highfive @Manishearth @bors-servo @jdm
You can’t perform that action at this time.