Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yet another batch of arbitrary improvements to our WebGL stuff #21701

Merged
merged 6 commits into from Sep 13, 2018
Merged

Yet another batch of arbitrary improvements to our WebGL stuff #21701

merged 6 commits into from Sep 13, 2018
+70 −108

Conversation

@nox
Copy link
Member

nox commented Sep 13, 2018 •
edited by SimonSapin

This change is Reviewable
@highfive
Copy link

highfive commented Sep 13, 2018

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webglrenderingcontext.rs
  • @jgraham: tests/wpt/webgl/meta/conformance2/renderbuffers/framebuffer-test.html.ini, tests/wpt/webgl/meta/conformance/misc/object-deletion-behaviour.html.ini, tests/wpt/webgl/meta/conformance/extensions/oes-texture-half-float-with-video.html.ini, tests/wpt/webgl/meta/conformance/renderbuffers/framebuffer-state-restoration.html.ini, tests/wpt/webgl/meta/conformance/canvas/to-data-url-test.html.ini and 14 more
  • @KiChjang: components/script/dom/webglrenderingcontext.rs
@jdm
Copy link
Member

jdm commented Sep 13, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Sep 13, 2018

📌 Commit c26afb2 has been approved by jdm
@highfive highfive assigned jdm and unassigned paulrouget Sep 13, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Sep 13, 2018

⌛ Testing commit c26afb2 with merge d302943...
bors-servo added a commit that referenced this pull request Sep 13, 2018
@bors-servo
Auto merge of #21701 - servo:webgl, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d302943 
Yet another batch of arbitrary improvements to our WebGL stuff

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21701)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 13, 2018

💔 Test failed - linux-rel-wpt
@jdm
Copy link
Member

jdm commented Sep 13, 2018

Uh oh.

  ▶ TIMEOUT [expected OK] /_webgl/conformance/reading/read-pixels-test.html
  │ 
  │ VMware, Inc.
  │ softpipe
  │ 3.3 (Core Profile) Mesa 18.1.0-devel
  │ DESCRIPTION: Checks that ReadPixels works as expected.
  │ 
  │ checking: in range
  │ PASS color pixel at 0, 0 should be about 51,153,102,255, was = 51,153,102,255
  │ PASS color pixel at 1, 0 should be about 51,153,102,255, was = 51,153,102,255
  │ PASS color pixel at 0, 1 should be about 51,153,102,255, was = 51,153,102,255
  │ PASS color pixel at 1, 1 should be about 51,153,102,255, was = 51,153,102,255
  │ 
  │ checking: off top left
  │ PASS color pixel at 0, 0 should be about 19,72,0,198, was = 19,72,0,198
  │ PASS color pixel at 1, 0 should be about 19,72,0,198, was = 19,72,0,198
  │ PASS color pixel at 0, 1 should be about 19,72,0,198, was = 19,72,0,198
  │ PASS color pixel at 1, 1 should be about 51,153,102,255, was = 51,153,102,255
  │ 
  │ checking: off bottom right
  │ PASS color pixel at 0, 0 should be about 51,153,102,255, was = 51,153,102,255
  │ FAIL color pixel at 1, 0 should be about 19,72,0,198, was = 51,153,102,255
  │ FAIL color pixel at 0, 1 should be about 19,72,0,198, was = 51,153,102,255
  │ FAIL color pixel at 1, 1 should be about 19,72,0,198, was = 51,153,102,255
  │ 
  │ checking: completely off top
  │ PASS color pixel at 0, 0 should be about 19,72,0,198, was = 19,72,0,198
  │ PASS color pixel at 1, 0 should be about 19,72,0,198, was = 19,72,0,198
  │ PASS color pixel at 0, 1 should be about 19,72,0,198, was = 19,72,0,198
  │ PASS color pixel at 1, 1 should be about 19,72,0,198, was = 19,72,0,198
  │ 
  │ checking: completely off bottom
  │ FAIL color pixel at 0, 0 should be about 19,72,0,198, was = 51,153,102,255
  │ FAIL color pixel at 1, 0 should be about 19,72,0,198, was = 51,153,102,255
  │ FAIL color pixel at 0, 1 should be about 19,72,0,198, was = 51,153,102,255
  │ FAIL color pixel at 1, 1 should be about 19,72,0,198, was = 51,153,102,255
  │ 
  │ checking: completely off left
  │ PASS color pixel at 0, 0 should be about 19,72,0,198, was = 19,72,0,198
  │ PASS color pixel at 1, 0 should be about 19,72,0,198, was = 19,72,0,198
  │ PASS color pixel at 0, 1 should be about 19,72,0,198, was = 19,72,0,198
  │ PASS color pixel at 1, 1 should be about 19,72,0,198, was = 19,72,0,198
  │ 
  │ checking: completeley off right
  │ FAIL color pixel at 0, 0 should be about 19,72,0,198, was = 51,153,102,255
  │ FAIL color pixel at 1, 0 should be about 19,72,0,198, was = 51,153,102,255
  │ FAIL color pixel at 0, 1 should be about 19,72,0,198, was = 51,153,102,255
  │ FAIL color pixel at 1, 1 should be about 19,72,0,198, was = 51,153,102,255
  │ PASS getError was expected value: NO_ERROR : there should be no GL errors
  │ 
  │ check invalid format or type
  │ FAIL getError expected: INVALID_ENUM. Was INVALID_OPERATION : Should not be able to read as DEPTH_COMPONENT
  │ FAIL getError expected: INVALID_ENUM. Was INVALID_OPERATION : Should not be able to read as DEPTH_STENCIL
  │ FAIL getError expected: INVALID_ENUM. Was INVALID_OPERATION : Should not be able to read as 0x8229
  │ FAIL getError expected: INVALID_ENUM. Was INVALID_OPERATION : Should not be able to read as RGBA4
  │ FAIL getError expected: INVALID_ENUM. Was INVALID_OPERATION : Should not be able to read as LUMINANCE
  │ FAIL getError expected: INVALID_ENUM. Was INVALID_OPERATION : Should not be able to read as LUMINANCE_ALPHA
  │ FAIL getError expected: INVALID_ENUM. Was INVALID_OPERATION : Should not be able to read as 0x1903
  │ FAIL getError expected: INVALID_ENUM. Was INVALID_OPERATION : Should not be able to read as 0x8228
  │ FAIL getError expected: INVALID_ENUM. Was INVALID_OPERATION : Should not be able to read as 0x8d99
  │ FAIL getError expected: INVALID_ENUM. Was INVALID_OPERATION : Should not be able to read as 0x84fa
  │ FAIL getError expected: INVALID_ENUM. Was INVALID_OPERATION : Should not be able to read as UNSIGNED_SHORT
  │ FAIL getError expected: INVALID_ENUM. Was INVALID_OPERATION : Should not be able to read as SHORT
  │ FAIL getError expected: INVALID_ENUM. Was INVALID_OPERATION : Should not be able to read as BYTE
  │ FAIL getError expected: INVALID_ENUM. Was INVALID_OPERATION : Should not be able to read as UNSIGNED_INT
  │ FAIL getError expected: INVALID_ENUM. Was INVALID_OPERATION : Should not be able to read as 0x8368
  │ 
  │ check invalid combinations of format/type
  │ PASS getError was expected value: NO_ERROR : Should be able to read as RGBA / UNSIGNED_BYTE
  │ PASS getError was expected value: INVALID_OPERATION : Should not be able to read as RGB / UNSIGNED_BYTE
  │ PASS getError was expected value: INVALID_OPERATION : Should not be able to read as RGB / UNSIGNED_SHORT_5_6_5
  │ PASS getError was expected value: INVALID_OPERATION : Should not be able to read as RGBA / UNSIGNED_SHORT_5_5_5_1
  │ PASS getError was expected value: INVALID_OPERATION : Should not be able to read as RGBA / UNSIGNED_SHORT_4_4_4_4
  │ PASS getError was expected value: INVALID_OPERATION : Should not be able to read as ALPHA / UNSIGNED_BYTE
  │ 
  └ check reading with lots of drawing
@nox nox force-pushed the webgl branch from c26afb2 to 7d4c34b Sep 13, 2018
@jdm
Copy link
Member

jdm commented Sep 13, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Sep 13, 2018

📌 Commit 7c8196b has been approved by jdm
@jdm jdm mentioned this pull request Sep 13, 2018
Closed
@bors-servo
Copy link
Contributor

bors-servo commented Sep 13, 2018

⌛ Testing commit 7c8196b with merge b56bd67...
bors-servo added a commit that referenced this pull request Sep 13, 2018
@bors-servo
Auto merge of #21701 - servo:webgl, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b56bd67 
Yet another batch of arbitrary improvements to our WebGL stuff

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21701)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 13, 2018

💔 Test failed - mac-rel-wpt1
@nox
Copy link
Member Author

nox commented Sep 13, 2018

@bors-servo retry #20734
@bors-servo
Copy link
Contributor

bors-servo commented Sep 13, 2018

⌛ Testing commit 7c8196b with merge cfc80f8...
bors-servo added a commit that referenced this pull request Sep 13, 2018
@bors-servo
Auto merge of #21701 - servo:webgl, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
cfc80f8 
Yet another batch of arbitrary improvements to our WebGL stuff

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21701)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 13, 2018

💔 Test failed - mac-rel-wpt1
@jdm
Copy link
Member

jdm commented Sep 13, 2018

I am chuckling.

  ▶ TIMEOUT [expected OK] /_webgl/conformance/canvas/rapid-resizing.html
  │ 
  │ VMware, Inc.
  │ softpipe
  │ 3.3 (Core Profile) Mesa 18.1.0-devel
  │ ERROR 2018-09-13T19:48:52Z: script::dom::webglrenderingcontext: Couldn't create WebGLRenderingContext: preserveDrawingBuffer is not supported yet
  │ ERROR 2018-09-13T19:48:53Z: script::dom::webglrenderingcontext: Couldn't create WebGLRenderingContext: preserveDrawingBuffer is not supported yet
  │ DESCRIPTION: Verifies that rapidly resizing the canvas works correctly.
  │ 
  │ Regression test for Chromium <a href='http://crbug.com/299371'>Issue 299371</a> and <a href='http://crbug.com/557848'>Issue 557848</a>
  │ 
  │ requestAnimationFrame
  │ Testing preserveDrawingBuffer = true
  │ FAIL Unable to fetch WebGL rendering context for Canvas
  │ FAIL context does not exist
  │ Testing preserveDrawingBuffer = false
  │ PASS context exists
  │ PASS program is non-null.
  │ PASS lower left should be green
  │ PASS lower right should be green
  │ PASS upper left should be green
  │ PASS upper right should be green
  │ PASS lower left should be green
  │ PASS lower right should be green
  │ PASS upper left should be green
  │ PASS upper right should be green
  │ PASS lower left should be green
  │ PASS lower right should be green
  │ PASS upper left should be green
  │ PASS upper right should be green
  │ PASS lower left should be green
  │ PASS lower right should be green
  │ PASS upper left should be green
  │ PASS upper right should be green
  │ PASS lower left should be green
  │ PASS lower right should be green
  │ PASS upper left should be green
  │ PASS upper right should be green
  │ PASS lower left should be green
  │ PASS lower right should be green
  │ PASS upper left should be green
  │ PASS upper right should be green
  │ PASS lower left should be green
  │ PASS lower right should be green
  │ PASS upper left should be green
  │ PASS upper right should be green
  │ PASS lower left should be green
  │ PASS lower right should be green
  │ PASS upper left should be green
  │ PASS upper right should be green
  │ PASS lower left should be green
  │ PASS lower right should be green
  │ PASS upper left should be green
  │ PASS upper right should be green
  │ PASS lower left should be green
  │ PASS lower right should be green
  │ PASS upper left should be green
  │ PASS upper right should be green
  │ PASS lower left should be green
  │ PASS lower right should be green
  │ PASS upper left should be green
  │ PASS upper right should be green
  │ PASS lower left should be green
  │ PASS lower right should be green
  │ PASS upper left should be green
  │ PASS upper right should be green
  │ PASS lower left should be green
  │ PASS lower right should be green
  │ PASS upper left should be green
  │ PASS upper right should be green
  │ PASS lower left should be green
  │ PASS lower right should be green
  │ PASS upper left should be green
  │ PASS upper right should be green
  │ PASS lower left should be green
  │ PASS lower right should be green
  │ PASS upper left should be green
  │ PASS upper right should be green
  │ PASS lower left should be green
  │ PASS lower right should be green
  │ PASS upper left should be green
  │ PASS upper right should be green
  │ PASS lower left should be green
  │ PASS lower right should be green
  │ PASS upper left should be green
  │ PASS upper right should be green
  │ PASS lower left should be green
  │ PASS lower right should be green
  │ PASS upper left should be green
  │ PASS upper right should be green
  │ PASS lower left should be green
  │ PASS lower right should be green
  │ PASS upper left should be green
  │ PASS upper right should be green
  │ PASS lower left should be green
  │ PASS lower right should be green
  │ PASS upper left should be green
  │ PASS upper right should be green
  │ PASS lower left should be green
  │ PASS lower right should be green
  │ PASS upper left should be green
  │ PASS upper right should be green
  │ PASS lower left should be green
  │ PASS lower right should be green
  │ PASS upper left should be green
  │ PASS upper right should be green
  │ PASS lower left should be green
  │ PASS lower right should be green
  │ PASS upper left should be green
  │ PASS upper right should be green
  │ PASS lower left should be green
  │ PASS lower right should be green
  │ PASS upper left should be green
  │ PASS upper right should be green
  │ PASS lower left should be green
  │ PASS lower right should be green
  │ PASS upper left should be green
  │ PASS upper right should be green
  │ PASS lower left should be green
  │ PASS lower right should be green
  │ PASS upper left should be green
  │ PASS upper right should be green
  │ PASS lower left should be green
  │ PASS lower right should be green
  │ PASS upper left should be green
  │ PASS upper right should be green
  │ PASS lower left should be green
  │ PASS lower right should be green
  │ PASS upper left should be green
  │ PASS upper right should be green
  │ PASS lower left should be green
  │ PASS lower right should be green
  │ PASS upper left should be green
  │ PASS upper right should be green
  │ PASS lower left should be green
  │ PASS lower right should be green
  │ PASS upper left should be green
  │ PASS upper right should be green
  │ PASS lower left should be green
  │ PASS lower right should be green
  │ PASS upper left should be green
  │ PASS upper right should be green
  │ PASS lower left should be green
  │ PASS lower right should be green
  │ PASS upper left should be green
  │ PASS upper right should be green
  │ PASS lower left should be green
  │ PASS lower right should be green
  │ PASS upper left should be green
  │ PASS upper right should be green
  │ PASS lower left should be green
  │ PASS lower right should be green
  │ PASS upper left should be green
  │ PASS upper right should be green
  │ PASS lower left should be green
  │ PASS lower right should be green
  │ PASS upper left should be green
  │ PASS upper right should be green
  │ PASS lower left should be green
  │ PASS lower right should be green
  │ PASS upper left should be green
  │ PASS upper right should be green
  │ PASS lower left should be green
  │ PASS lower right should be green
  │ PASS upper left should be green
  │ PASS upper right should be green
  │ PASS lower left should be green
  │ PASS lower right should be green
  │ PASS upper left should be green
  │ PASS upper right should be green
  │ PASS lower left should be green
  │ PASS lower right should be green
  │ PASS upper left should be green
  │ PASS upper right should be green
  │ PASS lower left should be green
  │ PASS lower right should be green
  │ PASS upper left should be green
  │ PASS upper right should be green
  │ PASS lower left should be green
  │ PASS lower right should be green
  │ PASS upper left should be green
  │ PASS upper right should be green
  │ PASS lower left should be green
  │ PASS lower right should be green
  │ PASS upper left should be green
  │ PASS upper right should be green
  │ PASS lower left should be green
  │ PASS lower right should be green
  │ PASS upper left should be green
  │ PASS upper right should be green
  │ PASS lower left should be green
  │ PASS lower right should be green
  │ PASS upper left should be green
  │ PASS upper right should be green
  │ PASS lower left should be green
  │ PASS lower right should be green
  │ PASS upper left should be green
  │ PASS upper right should be green
  │ PASS lower left should be green
  │ PASS lower right should be green
  │ PASS upper left should be green
  │ PASS upper right should be green
  │ PASS lower left should be green
  │ PASS lower right should be green
  │ PASS upper left should be green
  │ PASS upper right should be green
  │ PASS lower left should be green
  │ PASS lower right should be green
  │ PASS upper left should be green
  │ PASS upper right should be green
  │ PASS lower left should be green
  │ PASS lower right should be green
  │ PASS upper left should be green
  │ PASS upper right should be green
  │ PASS lower left should be green
  │ PASS lower right should be green
  │ PASS upper left should be green
  │ PASS upper right should be green
  │ PASS lower left should be green
  │ PASS lower right should be green
  │ PASS upper left should be green
  │ PASS upper right should be green
  │ PASS lower left should be green
  │ PASS lower right should be green
  │ PASS upper left should be green
  │ PASS upper right should be green
  │ PASS lower left should be green
  │ PASS lower right should be green
  │ PASS upper left should be green
  │ PASS upper right should be green
  │ PASS lower left should be green
  │ PASS lower right should be green
  │ PASS upper left should be green
  │ PASS upper right should be green
  │ PASS lower left should be green
  │ PASS lower right should be green
  │ PASS upper left should be green
  └ PASS upper right should be green

  ▶ Unexpected subtest result in /_webgl/conformance/canvas/rapid-resizing.html:
  └ NOTRUN [expected PASS] Overall test
nox added 6 commits Sep 12, 2018
@nox
Add some bug links in expectations
c7a54cc
@nox
Update some outdated WebGL expectations
9db1a5c
@nox
Remove erroneous check from CopyTexImage2D
ac822ee 
The internal format of the bound texture doesn't matter, what matters is
which components can be found in the framebuffer.
@nox
Mark shader-uniform-packing-restrictions.html as long-running
983a914
@nox
Merge byte swap and unmultiplying loops in ctx.getImageData()
b5c469d
@nox
Use a byte channel to retrieve pixels of 2D canvas
Loading status checks…
2f2331f
@nox nox force-pushed the webgl branch from 7c8196b to 2f2331f Sep 13, 2018
@nox
Copy link
Member Author

nox commented Sep 13, 2018

@bors-servo r=jdm
@bors-servo
Copy link
Contributor

bors-servo commented Sep 13, 2018

📌 Commit 2f2331f has been approved by jdm
bors-servo added a commit that referenced this pull request Sep 13, 2018
@bors-servo
Auto merge of #21701 - servo:webgl, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
93fbc15 
Yet another batch of arbitrary improvements to our WebGL stuff

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21701)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 13, 2018

⌛ Testing commit 2f2331f with merge 93fbc15...
@bors-servo
Copy link
Contributor

bors-servo commented Sep 13, 2018

💔 Test failed - linux-rel-wpt
@nox
Copy link
Member Author

nox commented Sep 13, 2018

@bors-servo retry

Network issues it seems.
@bors-servo
Copy link
Contributor

bors-servo commented Sep 13, 2018

⚡ Previous build results for android, android-x86, arm32, arm64, linux-dev, linux-rel-css, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only linux-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Sep 13, 2018

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: jdm
Pushing 93fbc15 to master...
@bors-servo bors-servo merged commit 2f2331f into master Sep 13, 2018
1 of 4 checks passed
1 of 4 checks passed
Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@nox @highfive @jdm @bors-servo @paulrouget
You can’t perform that action at this time.