Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement AnalyserNode #21712
Implement AnalyserNode #21712
Conversation
highfive
commented
Sep 14, 2018
|
Heads up! This PR modifies the following files:
|
highfive
commented
Sep 14, 2018
|
|
|
Opened new PR for upstreamable changes. Completed upstream sync of web-platform-test changes at jdm/web-platform-tests#85. |
|
Transplanted upstreamable changes to existing PR. Completed upstream sync of web-platform-test changes at jdm/web-platform-tests#85. |
|
@bors-servo try=wpt |
Implement AnalyserNode <s>Needs servo/media#127 to land (and a dependency update)</s> r? @ferjm realtimeanalyser-fft-scaling.html, the test that actually checks for some level of FFT correctness, sadly doesn't work since we don't process nodes not connected to the destination. However I locally fixed the test to work differently and it passed. We'll fix the processing model eventually. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21712) <!-- Reviewable:end -->
|
Transplanted upstreamable changes to existing PR. Completed upstream sync of web-platform-test changes at jdm/web-platform-tests#85. |
|
|
|
@bors-servo try=wpt |
Implement AnalyserNode <s>Needs servo/media#127 to land (and a dependency update)</s> r? @ferjm realtimeanalyser-fft-scaling.html, the test that actually checks for some level of FFT correctness, sadly doesn't work since we don't process nodes not connected to the destination. However I locally fixed the test to work differently and it passed. We'll fix the processing model eventually. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21712) <!-- Reviewable:end -->
|
|
|
Transplanted upstreamable changes to existing PR. Completed upstream sync of web-platform-test changes at jdm/web-platform-tests#85. |
|
r=me (remove the patched servo-media before merging, please) |
|
@bors-servo r=ferjm |
|
|
|
@bors-servo r=ferjm missed a WPT update outside of the |
|
|
Implement AnalyserNode <s>Needs servo/media#127 to land (and a dependency update)</s> r? @ferjm realtimeanalyser-fft-scaling.html, the test that actually checks for some level of FFT correctness, sadly doesn't work since we don't process nodes not connected to the destination. However I locally fixed the test to work differently and it passed. We'll fix the processing model eventually. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21712) <!-- Reviewable:end -->
|
Transplanted upstreamable changes to existing PR. Completed upstream sync of web-platform-test changes at jdm/web-platform-tests#85. |
|
|
|
@bors-servo retry |
Implement AnalyserNode <s>Needs servo/media#127 to land (and a dependency update)</s> r? @ferjm realtimeanalyser-fft-scaling.html, the test that actually checks for some level of FFT correctness, sadly doesn't work since we don't process nodes not connected to the destination. However I locally fixed the test to work differently and it passed. We'll fix the processing model eventually. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21712) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
|
|
|
|
|
Error syncing changes upstream. Logs saved in error-snapshot-1537316339325. |
This was deliberately changed (WebAudio/web-audio-api#1397 ) but the tests have not been updated Upstreamed from servo/servo#21712 [ci skip]
Manishearth commentedSep 14, 2018
•
edited
Needs servo/media#127 to land (and a dependencyupdate)
r? @ferjm
realtimeanalyser-fft-scaling.html, the test that actually checks for some level of FFT correctness, sadly doesn't work since we don't process nodes not connected to the destination.
However I locally fixed the test to work differently and it passed. We'll fix the processing model eventually.
This change is