Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement AnalyserNode #21712

Merged
merged 8 commits into from Sep 19, 2018
Merged
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Set default channel count for AnalyserNode to 2

This was deliberately changed
(WebAudio/web-audio-api#1397 ) but the tests
have not been updated
  • Loading branch information
Manishearth committed Sep 18, 2018
commit e9be17995226b445ec9c83b9b21d84b4c87a0838
@@ -38,7 +38,7 @@ impl AnalyserNode {
options: &AnalyserOptions,
) -> Fallible<(AnalyserNode, IpcReceiver<Block>)> {
let node_options = options.parent
.unwrap_or(1, ChannelCountMode::Max,
.unwrap_or(2, ChannelCountMode::Max,
ChannelInterpretation::Speakers);

if options.fftSize > 32768 || options.fftSize < 32 ||
"support"
],
"webaudio/the-audio-api/the-analysernode-interface/ctor-analyser.html": [
"4e27f842ddeda3e2bdd78da7b8ee3f67062d1a9f",
"a9aa4831516c6a5cefa7c8b4f67f3ef246d24777",
"testharness"
],
"webaudio/the-audio-api/the-analysernode-interface/realtimeanalyser-basic.html": [
"testharness"
],
"webaudio/the-audio-api/the-analysernode-interface/test-analysernode.html": [
"52d3829cff3dfceef64a34669bc8e0d6e08883a9",
"a8b5a7154e94479460c1085c6b5cb584e9b6976c",
"testharness"
],
"webaudio/the-audio-api/the-audiobuffer-interface/.gitkeep": [

This file was deleted.

@@ -32,7 +32,7 @@
prefix: prefix,
numberOfInputs: 1,
numberOfOutputs: 1,
channelCount: 1,
channelCount: 2,
channelCountMode: 'max',
channelInterpretation: 'speakers'
});
@@ -27,8 +27,8 @@

assert_equals(
analyser.channelCount,
1,
"analyser node has 1 input channels by default"
2,
"analyser node has 2 input channels by default"
);
assert_equals(
analyser.channelCountMode,
@@ -131,8 +131,8 @@
var analyser = new AnalyserNode(context);
assert_equals(
analyser.channelCount,
1,
"analyser node has 1 input channels by default"
2,
"analyser node has 2 input channels by default"
);
assert_equals(
analyser.channelCountMode,
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.