Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tests for uninitialized renderbuffers pass #21717

Merged
merged 3 commits into from Sep 15, 2018
Merged

Make tests for uninitialized renderbuffers pass #21717

merged 3 commits into from Sep 15, 2018

Conversation

@jdm
Copy link
Member

jdm commented Sep 14, 2018 •
edited

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #13710
  • There are tests for these changes

This change is Reviewable
@jdm
webgl: Mark framebuffers as uninitialized when their attached renderb…
Loading status checks…
59b8f97 
…uffer's storage changes.
@highfive
Copy link

highfive commented Sep 14, 2018

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webglframebuffer.rs, components/script/dom/webglrenderbuffer.rs
  • @jgraham: tests/wpt/webgl/meta/conformance/misc/uninitialized-test.html.ini, tests/wpt/webgl/meta/conformance/renderbuffers/stencil-renderbuffer-initialization.html.ini, tests/wpt/webgl/meta/conformance/renderbuffers/depth-renderbuffer-initialization.html.ini, tests/wpt/webgl/meta/conformance/renderbuffers/renderbuffer-initialization.html.ini
  • @KiChjang: components/script/dom/webglframebuffer.rs, components/script/dom/webglrenderbuffer.rs
jdm added 2 commits Sep 14, 2018
@jdm
Add bug reference for drawingbuffer-test.html.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3d3a325
@jdm
Annotate bug for gl-pointcoord.html.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ac1d505
@nox
Copy link
Member

nox commented Sep 14, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Sep 14, 2018

📌 Commit ac1d505 has been approved by nox
@highfive highfive assigned nox and unassigned paulrouget Sep 14, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Sep 14, 2018

⌛ Testing commit ac1d505 with merge 9a9b4b2...
bors-servo added a commit that referenced this pull request Sep 14, 2018
@bors-servo
Auto merge of #21717 - jdm:webgltmp5, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9a9b4b2 
Make tests for uninitialized renderbuffers pass

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #13710
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21717)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 14, 2018

💔 Test failed - mac-rel-wpt3
@jdm
Copy link
Member Author

jdm commented Sep 14, 2018

@bors-servo retry

  • network
@bors-servo
Copy link
Contributor

bors-servo commented Sep 14, 2018

⚡ Previous build results for android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3...
@bors-servo
Copy link
Contributor

bors-servo commented Sep 15, 2018

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: nox
Pushing 9a9b4b2 to master...
@bors-servo bors-servo merged commit ac1d505 into servo:master Sep 15, 2018
2 of 4 checks passed
2 of 4 checks passed
Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

webgl: uninitialized data leak from renderbufferStorage()
5 participants
@jdm @highfive @nox @bors-servo @paulrouget
You can’t perform that action at this time.