New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More drive-by WebGL and canvas fixes #21723

Merged
merged 9 commits into from Sep 18, 2018

Conversation

Projects
None yet
4 participants
@nox
Member

nox commented Sep 15, 2018

This change is Reviewable

@highfive

This comment has been minimized.

highfive commented Sep 15, 2018

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/htmlcanvaselement.rs, components/script/dom/canvasrenderingcontext2d.rs
  • @KiChjang: components/script/dom/htmlcanvaselement.rs, components/script/dom/canvasrenderingcontext2d.rs
@highfive

This comment has been minimized.

highfive commented Sep 15, 2018

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify script code, but no tests are modified. Please consider adding a test!
@nox

This comment has been minimized.

Member

nox commented Sep 15, 2018

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Sep 15, 2018

⌛️ Trying commit 854dedd with merge f6c3898...

bors-servo added a commit that referenced this pull request Sep 15, 2018

Auto merge of #21723 - servo:webgl, r=<try>
Don't create 2D canvas contexts arbitrarily

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21723)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Sep 15, 2018

💔 Test failed - mac-rel-wpt2

@nox

This comment has been minimized.

Member

nox commented Sep 15, 2018

@bors-servo retry

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Sep 15, 2018

⌛️ Trying commit 854dedd with merge eca5c20...

bors-servo added a commit that referenced this pull request Sep 15, 2018

Auto merge of #21723 - servo:webgl, r=<try>
Don't create 2D canvas contexts arbitrarily

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21723)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Sep 15, 2018

@nox nox removed the S-tests-failed label Sep 16, 2018

nox added some commits Sep 14, 2018

Mark some canvas methods as unsafe
They use raw JS context pointers.
Don't create 2D canvas contexts arbitrarily
Sometimes, the canvas still has no rendering context, in this case it represents
a transparent black rectangle.

@nox nox force-pushed the webgl branch from 854dedd to 21e992b Sep 16, 2018

@nox nox force-pushed the webgl branch 2 times, most recently from aae8407 to 2995324 Sep 17, 2018

Remove Canvas2dMsg::DrawImageSelf
Now that all canvas share the same thread, it's useless to have a separate message
for that.

@nox nox force-pushed the webgl branch from 2995324 to 36c8cd2 Sep 17, 2018

@jdm

jdm approved these changes Sep 17, 2018

@jdm

This comment has been minimized.

Member

jdm commented Sep 17, 2018

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Sep 17, 2018

📌 Commit a6d1089 has been approved by jdm

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Sep 17, 2018

⌛️ Testing commit a6d1089 with merge 6e651ae...

bors-servo added a commit that referenced this pull request Sep 17, 2018

Auto merge of #21723 - servo:webgl, r=jdm
Don't create 2D canvas contexts arbitrarily

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21723)
<!-- Reviewable:end -->

@nox nox changed the title from Don't create 2D canvas contexts arbitrarily to Implement proper origin checks for WebGL textures (fixes #21522) Sep 17, 2018

@nox nox force-pushed the webgl branch from 022ceab to 32d4565 Sep 17, 2018

@nox nox force-pushed the webgl branch from 32d4565 to 8c100b2 Sep 18, 2018

@nox

This comment has been minimized.

Member

nox commented Sep 18, 2018

@bors-servo try=wpt

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Sep 18, 2018

⌛️ Trying commit fe6f53f with merge d7e4ecc...

bors-servo added a commit that referenced this pull request Sep 18, 2018

Auto merge of #21723 - servo:webgl, r=<try>
Implement proper origin checks for WebGL textures (fixes #21522)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21723)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Sep 18, 2018

☀️ Test successful - linux-rel-css, linux-rel-wpt
State: approved= try=True

@nox nox changed the title from Implement proper origin checks for WebGL textures (fixes #21522) to More drive-by WebGL and canvas fixes Sep 18, 2018

@jdm

This comment has been minimized.

Member

jdm commented Sep 18, 2018

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Sep 18, 2018

📌 Commit 900c3cc has been approved by jdm

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Sep 18, 2018

⌛️ Testing commit 900c3cc with merge 5385f46...

bors-servo added a commit that referenced this pull request Sep 18, 2018

Auto merge of #21723 - servo:webgl, r=jdm
More drive-by WebGL and canvas fixes

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21723)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Sep 18, 2018

💔 Test failed - linux-rel-css

@nox

This comment has been minimized.

Member

nox commented Sep 18, 2018

@bors-servo retry

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Sep 18, 2018

⌛️ Testing commit 900c3cc with merge 82e94e3...

bors-servo added a commit that referenced this pull request Sep 18, 2018

Auto merge of #21723 - servo:webgl, r=jdm
More drive-by WebGL and canvas fixes

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21723)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Sep 18, 2018

@bors-servo bors-servo merged commit 900c3cc into master Sep 18, 2018

2 of 4 checks passed

Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment