Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Sync changes from mozilla-central #21724

Merged
merged 10 commits into from Sep 15, 2018
Merged

style: Sync changes from mozilla-central #21724

merged 10 commits into from Sep 15, 2018
+239 −68

Conversation

@emilio
Copy link
Member

emilio commented Sep 15, 2018 •
edited by SimonSapin

See each individual commit for details.

This change is Reviewable
emilio and others added 7 commits Sep 7, 2018
@emilio
style: Teach ComputeSquaredDistance derive about #[animation(constant)].
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
25db9e3 
Differential Revision: https://phabricator.services.mozilla.com/D5337
@emilio
style: Remove unused nsStyleFont::{EnableZoom, UnZoomText}.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
ca335ba 
Differential Revision: https://phabricator.services.mozilla.com/D5530
@bradwerth @emilio
style: Change Gecko_ImageValue_Create to take a CORS mode argument.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
b96d44e 
Differential Revision: https://phabricator.services.mozilla.com/D5106
@bradwerth @emilio
style: Expand the Parser trait to allow anonymous CORS to be applied.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
6d57cbd 
Depends on D5106

Differential Revision: https://phabricator.services.mozilla.com/D5341
@heycam @emilio
style: Update comments to no longer point to nsRuleNode.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
1f45fc0 
There are a few mentions of nsRuleNode left but they are mostly
historical references so it makes sense to keep them.

Differential Revision: https://phabricator.services.mozilla.com/D5505
Hiroyuki Ikezoe @emilio
style: Add media feature keys for hover and pointer.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
9354a42 
https://drafts.csswg.org/mediaqueries-4/#hover
https://drafts.csswg.org/mediaqueries-4/#pointer

In this patch series, we don't introduce any-hover and any-pointer media
features yet, but functionalities for them on each platform backends will be
introduced in this patch series, so eIntID_AllPointerCapabilities and relevant
stuff is added in this patch for the convenience that each platform backends
can be reviewed at once.

Differential Revision: https://phabricator.services.mozilla.com/D3296
Hiroyuki Ikezoe @emilio
style: Implement any-hover and any-pointer media queries features.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
3d90913 
Differential Revision: https://phabricator.services.mozilla.com/D3609
@highfive
Copy link

highfive commented Sep 15, 2018

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style code, but no tests are modified. Please consider adding a test!
emilio added 3 commits Sep 15, 2018
@emilio
style: Fix Gecko build.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
da5283d
@emilio
style: Remove a useless type bound.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
8aeaa3f
@emilio
style: Fix servo build and drop a FIXME there.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
Loading status checks…
278ab86
@emilio emilio force-pushed the emilio:gecko-sync branch from ff797b9 to 278ab86 Sep 15, 2018
@emilio
Copy link
Member Author

emilio commented Sep 15, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Sep 15, 2018

📌 Commit 278ab86 has been approved by emilio
@highfive highfive assigned emilio and unassigned nox Sep 15, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Sep 15, 2018

⌛ Testing commit 278ab86 with merge 6c2f41b...
bors-servo added a commit that referenced this pull request Sep 15, 2018
@bors-servo
Auto merge of #21724 - emilio:gecko-sync, r=emilio
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6c2f41b 
style: Sync changes from mozilla-central

See each individual commit for details.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21724)
<!-- Reviewable:end -->
@emilio
Copy link
Member Author

emilio commented Sep 15, 2018

https://bugzilla.mozilla.org/show_bug.cgi?id=1491577
@bors-servo
Copy link
Contributor

bors-servo commented Sep 15, 2018

💔 Test failed - mac-rel-wpt1
@jdm
Copy link
Member

jdm commented Sep 15, 2018

@bors-servo retry #20734
@bors-servo
Copy link
Contributor

bors-servo commented Sep 15, 2018

⚡ Previous build results for android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only mac-rel-wpt1...
@bors-servo
Copy link
Contributor

bors-servo commented Sep 15, 2018

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: emilio
Pushing 6c2f41b to master...
@bors-servo bors-servo merged commit 278ab86 into servo:master Sep 15, 2018
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@emilio emilio deleted the emilio:gecko-sync branch Sep 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emilio emilio

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@emilio @highfive @bors-servo @jdm @nox @bradwerth @heycam
You can’t perform that action at this time.