Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention gstreamer LIB variable for Windows #21729

Merged
merged 1 commit into from Sep 17, 2018
Merged

Mention gstreamer LIB variable for Windows #21729

merged 1 commit into from Sep 17, 2018

Conversation

@Manishearth
Copy link
Member

Manishearth commented Sep 17, 2018 •
edited by SimonSapin

This got missed.

Ideally we'll get bootstrap to do all of this, but I haven't yet made
bootstrap work properly for Windows.

This change is Reviewable
@Manishearth
Mention gstreamer LIB variable for Windows
Loading status checks…
0b5c7e9
@Manishearth Manishearth mentioned this pull request Sep 17, 2018
Closed
@ferjm
Copy link
Member

ferjm commented Sep 17, 2018

In theory, this shouldn't be necessary after #21515. Note that we are not setting this on CI.
@Manishearth
Copy link
Member Author

Manishearth commented Sep 17, 2018

We do! It's set in the saltfs config
@Manishearth
Copy link
Member Author

Manishearth commented Sep 17, 2018

https://github.com/servo/saltfs/blob/master/buildbot/master/files/config/environments.py#L91
@ferjm
Copy link
Member

ferjm commented Sep 17, 2018

Oh, I was referring to AppVeyor But I guess that's ok because we don't run any tests there (other than unit tests).
@ferjm
Copy link
Member

ferjm commented Sep 17, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Sep 17, 2018

📌 Commit 0b5c7e9 has been approved by ferjm
@highfive highfive assigned ferjm and unassigned avadacatavra Sep 17, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Sep 17, 2018

⌛ Testing commit 0b5c7e9 with merge 605d74c...
bors-servo added a commit that referenced this pull request Sep 17, 2018
@bors-servo
Auto merge of #21729 - Manishearth:gstreamer-lib, r=ferjm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
605d74c 
Mention gstreamer LIB variable for Windows

This got missed.

Ideally we'll get bootstrap to do all of this, but I haven't yet made
bootstrap work properly for Windows.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21729)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 17, 2018

💔 Test failed - linux-rel-css
@ferjm
Copy link
Member

ferjm commented Sep 17, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Sep 17, 2018

⚡ Previous build results for android, android-x86, linux-dev, linux-rel-wpt, mac-dev-unit are reusable. Rebuilding only arm32, arm64, linux-rel-css, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev...
@bors-servo
Copy link
Contributor

bors-servo commented Sep 17, 2018

💔 Test failed - mac-rel-wpt3
@ferjm
Copy link
Member

ferjm commented Sep 17, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Sep 17, 2018

⚡ Previous build results for android, android-x86, arm32, arm64, linux-dev, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt4 are reusable. Rebuilding only linux-rel-css, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, windows-msvc-dev...
@bors-servo
Copy link
Contributor

bors-servo commented Sep 17, 2018

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: ferjm
Pushing 605d74c to master...
@bors-servo bors-servo merged commit 0b5c7e9 into servo:master Sep 17, 2018
2 of 4 checks passed
2 of 4 checks passed
Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@Manishearth Manishearth deleted the Manishearth:gstreamer-lib branch May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ferjm ferjm

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Manishearth @ferjm @bors-servo @highfive @avadacatavra
You can’t perform that action at this time.