Enable WebAudio on Android #21730

ferjm · 2018-09-17T16:01:14Z

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes fix #21619

This change is

highfive · 2018-09-17T16:01:19Z

Heads up! This PR modifies the following files:

@wafflespeanut: python/servo/build_commands.py

Manishearth · 2018-09-18T09:24:59Z

python/servo/build_commands.py

+            if not os.path.exists(gst_lib_path):
+                # Download GStreamer dependencies if they have not already been downloaded
+                print("Downloading GStreamer dependencies")
+                gst_url = "https://github.com/servo/libgstreamer_android_gen/blob/master/out/%s?raw=true" % gst_lib_zip


make sure this is eventually put on s3

ferjm · 2018-09-18T09:44:45Z

@bors-servo try

bors-servo · 2018-09-18T09:44:52Z

⌛ Trying commit 47d845e with merge 3b2e29d...


        Auto merge of #21730 - ferjm:android.gstreamer, r=<try>

[WIP] Enable WebAudio on Android - [X] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [X] These changes fix #21619  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21730)

bors-servo · 2018-09-18T09:48:29Z

💔 Test failed - android-x86

ferjm · 2018-09-18T14:27:08Z

@bors-servo try

bors-servo · 2018-09-18T14:27:13Z

⌛ Trying commit 2c8d790 with merge 7c1ca55...


        Auto merge of #21730 - ferjm:android.gstreamer, r=<try>

[WIP] Enable WebAudio on Android - [X] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [X] These changes fix #21619  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21730)

bors-servo · 2018-09-18T14:48:19Z

💔 Test failed - android-x86

ferjm · 2018-09-18T15:15:25Z

test ran test-android-startup --release ( 27 secs )
test__1 ran test-wpt-android --release /_mozilla/mozilla/DOMParser.html ( 33 secs )
test__2 ran test-wpt-android --release /_mozilla/mozilla/webgl/context_creation_error.html failed (

This seems to be happening for other builds with one of these two tests. See http://build.servo.org/builders/android-x86

ferjm · 2018-09-18T15:17:44Z

This seems to be happening for other builds with one of these two tests. See http://build.servo.org/builders/android-x86

And will hopefully be fixed by #21738

bors-servo · 2018-09-19T00:19:32Z

☔ The latest upstream changes (presumably #21712) made this pull request unmergeable. Please resolve the merge conflicts.

ferjm · 2018-09-20T15:14:07Z

@bors-servo try

bors-servo · 2018-09-24T08:07:32Z

☔ The latest upstream changes (presumably #21774) made this pull request unmergeable. Please resolve the merge conflicts.

paulrouget · 2018-09-24T09:40:54Z

support/android/apk/servoview/src/main/java/com/mozilla/servoview/ServoView.java

+              GStreamer.init((Context) mActivity);
+            } catch (Exception e) {
+              e.printStackTrace();
+            }


This code path is not used by ServoSurface. Move this in Servo.java.

paulrouget · 2018-09-24T09:46:07Z

support/android/apk/servoview/build.gradle

+
+            copyGStreamerObjTask.dependsOn taskName
+            copyGStreamerTask.dependsOn copyGStreamerObjTask
+            compileTask.dependsOn copyGStreamerTask


Could you add libgstreamer_android.so to LOCAL_SRC_FILES?


        Enable GStreamer support on Android


        Do not copy gstreamer fonts or certs on Android


        Use simpler way to build gst lib name


        Move GStreamer initialization to a path shared by ServoSurface and Se…

…rvoView


        Declare libgstreamer_android as prebuilt library

paulrouget · 2018-09-25T05:50:54Z

support/android/apk/servoview/src/main/java/com/mozilla/servoview/Servo.java

-            int width, int height, float density, boolean log) {
+            int width, int height,
+            float density, boolean log,
+            Context context) {



Context and activity are the same objects. Can you only pass one and cast activity to context or context to activity?

Ugh, of course. I'm blind.


        Remove duplicated context param from Servo constructor

paulrouget · 2018-09-25T10:52:40Z

r=me


        Update servo-media

ferjm · 2018-09-25T12:37:11Z

@bors-servo r=paulrouget

bors-servo · 2018-09-25T12:37:12Z

📌 Commit 879e391 has been approved by paulrouget

bors-servo · 2018-09-25T13:45:35Z

⌛ Testing commit 879e391 with merge 6e844f2...


        Auto merge of #21730 - ferjm:android.gstreamer, r=paulrouget

Enable WebAudio on Android - [X] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [X] These changes fix #21619  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21730)

bors-servo · 2018-09-25T14:29:36Z

💔 Test failed - mac-rel-wpt3

ferjm · 2018-09-25T14:55:08Z

@bors-servo retry

#18802

bors-servo · 2018-09-25T14:55:14Z

⚡ Previous build results for android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev are reusable. Rebuilding only mac-rel-css2, mac-rel-wpt3, mac-rel-wpt4...

bors-servo · 2018-09-25T15:45:08Z

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: paulrouget
Pushing 6e844f2 to master...

ferjm added the S-work-in-progress label Sep 17, 2018

highfive assigned emilio Sep 17, 2018

highfive added the S-awaiting-review label Sep 17, 2018

ferjm force-pushed the ferjm:android.gstreamer branch from df6af43 to 4b2a548 Sep 18, 2018

ferjm mentioned this pull request Sep 18, 2018

Enable Gstreamer backend for Android servo/media#129

Merged

Manishearth reviewed Sep 18, 2018

View changes

ferjm force-pushed the ferjm:android.gstreamer branch from 4b2a548 to 47d845e Sep 18, 2018

highfive added S-tests-failed and removed S-tests-failed labels Sep 18, 2018

highfive added the S-tests-failed label Sep 18, 2018

ferjm mentioned this pull request Sep 18, 2018

Try to use libfreetype, libexpat and libfontconfig from GStreamer on Android. #21739

Open

highfive added the S-needs-rebase label Sep 19, 2018

ferjm force-pushed the ferjm:android.gstreamer branch from 2c8d790 to 75dce31 Sep 20, 2018

highfive removed the S-tests-failed label Sep 20, 2018

ferjm removed S-needs-rebase S-work-in-progress labels Sep 20, 2018

ferjm changed the title ~~[WIP] Enable WebAudio on Android~~ Enable WebAudio on Android Sep 20, 2018

highfive added the S-needs-rebase label Sep 24, 2018

paulrouget reviewed Sep 24, 2018

View changes

ferjm added 5 commits Sep 17, 2018

Enable GStreamer support on Android

b278815

Do not copy gstreamer fonts or certs on Android

2854847

Use simpler way to build gst lib name

a4789de

Move GStreamer initialization to a path shared by ServoSurface and Se…

e3c9880

…rvoView

Declare libgstreamer_android as prebuilt library

Loading status checks…

991fdbe

ferjm force-pushed the ferjm:android.gstreamer branch from 89b1fba to 991fdbe Sep 24, 2018

ferjm removed the S-needs-rebase label Sep 24, 2018

paulrouget reviewed Sep 25, 2018

View changes

Remove duplicated context param from Servo constructor

Loading status checks…

c7d11b9

Update servo-media

Loading status checks…

879e391

highfive added S-awaiting-merge and removed S-awaiting-review labels Sep 25, 2018

highfive added S-tests-failed and removed S-awaiting-merge labels Sep 25, 2018

bors-servo mentioned this pull request Sep 25, 2018

Add mach command to setup remote debugging on Android devices. #21759

Merged

2 of 2 tasks complete

ferjm deleted the ferjm:android.gstreamer branch Sep 25, 2018

servo / servo

Enable WebAudio on Android #21730

Enable WebAudio on Android #21730

ferjm commented Sep 17, 2018 •

edited

highfive commented Sep 17, 2018

This comment has been minimized.

ferjm commented Sep 18, 2018

bors-servo commented Sep 18, 2018

bors-servo commented Sep 18, 2018

ferjm commented Sep 18, 2018

bors-servo commented Sep 18, 2018

bors-servo commented Sep 18, 2018

ferjm commented Sep 18, 2018

ferjm commented Sep 18, 2018

bors-servo commented Sep 19, 2018

ferjm commented Sep 20, 2018

bors-servo commented Sep 24, 2018

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

paulrouget commented Sep 25, 2018

ferjm commented Sep 25, 2018

bors-servo commented Sep 25, 2018

bors-servo commented Sep 25, 2018

bors-servo commented Sep 25, 2018

ferjm commented Sep 25, 2018

bors-servo commented Sep 25, 2018

bors-servo commented Sep 25, 2018

servo / servo

Join GitHub today

Enable WebAudio on Android #21730

Enable WebAudio on Android #21730

Conversation

ferjm commented Sep 17, 2018 • edited

highfive commented Sep 17, 2018

This comment has been minimized.

Manishearth Sep 18, 2018

ferjm commented Sep 18, 2018

bors-servo commented Sep 18, 2018

bors-servo commented Sep 18, 2018

ferjm commented Sep 18, 2018

bors-servo commented Sep 18, 2018

bors-servo commented Sep 18, 2018

ferjm commented Sep 18, 2018

ferjm commented Sep 18, 2018

bors-servo commented Sep 19, 2018

ferjm commented Sep 20, 2018

bors-servo commented Sep 24, 2018

This comment has been minimized.

paulrouget Sep 24, 2018

This comment has been minimized.

paulrouget Sep 24, 2018

This comment has been minimized.

paulrouget Sep 25, 2018

This comment has been minimized.

ferjm Sep 25, 2018

paulrouget commented Sep 25, 2018

ferjm commented Sep 25, 2018

bors-servo commented Sep 25, 2018

bors-servo commented Sep 25, 2018

bors-servo commented Sep 25, 2018

ferjm commented Sep 25, 2018

bors-servo commented Sep 25, 2018

bors-servo commented Sep 25, 2018

ferjm commented Sep 17, 2018 •

edited