Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd llvm to macOS required dependencies in docs #21731
Merged
Conversation
highfive
commented
Sep 17, 2018
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @nox (or someone else) soon. |
|
@bors-servo r+ thanks! |
|
|
bors-servo
added a commit
that referenced
this pull request
Sep 17, 2018
Add llvm to macOS required dependencies in docs <!-- Please describe your changes on the following line: --> @gterzian described it [in their comment](#21498 (comment)) pretty well: > latest "command line tools" that come with it(and include Apple's version of llvm), it might be that the current default Mac llvm is too old to compile the latest mozjs version(it appeared that after the OS update, no version of clang/llvm was installed until I downloaded the "new" command-line tools for the new OS) --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #21498 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because it's a change to markdown file. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21731) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
syniuhin commentedSep 17, 2018
•
edited by SimonSapin
@gterzian described it in their comment pretty well:
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is