Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return appropriate code from bootstrap_gstreamer #21734

Merged
merged 1 commit into from Sep 19, 2018
Merged

Return appropriate code from bootstrap_gstreamer #21734

merged 1 commit into from Sep 19, 2018

Conversation

@Manishearth
Copy link
Member

Manishearth commented Sep 18, 2018 •
edited by SimonSapin

Otherwise it exits with 1

This change is Reviewable
@highfive
Copy link

highfive commented Sep 18, 2018

Heads up! This PR modifies the following files:
@jankeromnes
jankeromnes reviewed Sep 18, 2018
View changes
Copy link

jankeromnes left a comment

Looks good! Thanks for the quick fix.

Just to be sure, if something terrible happens (e.g. network unreachable, exception, ...) this will still properly crash and report the error, right?
@Manishearth
Copy link
Member Author

Manishearth commented Sep 18, 2018

@jdm
Copy link
Member

jdm commented Sep 18, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Sep 18, 2018

📌 Commit 67b7f90 has been approved by jdm
@highfive highfive assigned jdm and unassigned SimonSapin Sep 18, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Sep 18, 2018

⌛ Testing commit 67b7f90 with merge 76b6aa3...
bors-servo added a commit that referenced this pull request Sep 18, 2018
@bors-servo
Auto merge of #21734 - Manishearth:bootstrap-retcode, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
76b6aa3 
Return appropriate code from bootstrap_gstreamer

Otherwise it exits with 1

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21734)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 18, 2018

💔 Test failed - linux-rel-wpt
@Manishearth
Return appropriate code from bootstrap_gstreamer
Loading status checks…
df5c31b
@Manishearth Manishearth force-pushed the Manishearth:bootstrap-retcode branch from 67b7f90 to df5c31b Sep 18, 2018
@Manishearth
Copy link
Member Author

Manishearth commented Sep 18, 2018

@bors-servo r=jdm
@bors-servo
Copy link
Contributor

bors-servo commented Sep 18, 2018

📌 Commit df5c31b has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Sep 18, 2018

⌛ Testing commit df5c31b with merge 8321619...
bors-servo added a commit that referenced this pull request Sep 18, 2018
@bors-servo
Auto merge of #21734 - Manishearth:bootstrap-retcode, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8321619 
Return appropriate code from bootstrap_gstreamer

Otherwise it exits with 1

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21734)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 18, 2018

💔 Test failed - android-x86
@Manishearth
Copy link
Member Author

Manishearth commented Sep 18, 2018

@bors-servo retry

  • EnvironmentError: Servers failed to start: 127.0.0.1:8889 , may be permabustage, cc @jdm
@bors-servo
Copy link
Contributor

bors-servo commented Sep 18, 2018

⌛ Testing commit df5c31b with merge 084f7cb...
bors-servo added a commit that referenced this pull request Sep 18, 2018
@bors-servo
Auto merge of #21734 - Manishearth:bootstrap-retcode, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
084f7cb 
Return appropriate code from bootstrap_gstreamer

Otherwise it exits with 1

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21734)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 18, 2018

💔 Test failed - android-x86
@jdm
Copy link
Member

jdm commented Sep 18, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Sep 19, 2018

⌛ Testing commit df5c31b with merge 3889041...
bors-servo added a commit that referenced this pull request Sep 19, 2018
@bors-servo
Auto merge of #21734 - Manishearth:bootstrap-retcode, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3889041 
Return appropriate code from bootstrap_gstreamer

Otherwise it exits with 1

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21734)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 19, 2018

💔 Test failed - mac-rel-css2
@jdm
Copy link
Member

jdm commented Sep 19, 2018

@bors-servo retry #21743
@bors-servo
Copy link
Contributor

bors-servo commented Sep 19, 2018

⚡ Previous build results for android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only mac-rel-css2...
@bors-servo
Copy link
Contributor

bors-servo commented Sep 19, 2018

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: jdm
Pushing 3889041 to master...
@bors-servo bors-servo merged commit df5c31b into servo:master Sep 19, 2018
2 of 4 checks passed
2 of 4 checks passed
Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@Manishearth Manishearth deleted the Manishearth:bootstrap-retcode branch Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jankeromnes jankeromnes

Assignees

@jdm jdm

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@Manishearth @highfive @jdm @bors-servo @jankeromnes @SimonSapin
You can’t perform that action at this time.