Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A couple of WebGL changes before lunch time #21747

Merged
merged 4 commits into from Sep 20, 2018
Merged
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Next

Remove some misplaced framebuffer validations

  • Loading branch information
nox committed Sep 20, 2018
commit 943f95fe4717459c845df7f6a10a039e5adf8e97
@@ -1303,19 +1303,9 @@ impl WebGLRenderingContextMethods for WebGLRenderingContext {
// GL_OES_read_format support (assuming an underlying GLES
// driver. Desktop is happy to format convert for us).
constants::IMPLEMENTATION_COLOR_READ_FORMAT => {
handle_potential_webgl_error!(
self,
self.validate_framebuffer(),
return NullValue()
);
return Int32Value(constants::RGBA as i32);
},
constants::IMPLEMENTATION_COLOR_READ_TYPE => {
handle_potential_webgl_error!(
self,
self.validate_framebuffer(),
return NullValue()
);
return Int32Value(constants::UNSIGNED_BYTE as i32);
},
constants::COMPRESSED_TEXTURE_FORMATS => {
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.