Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix most defaultPrevented test failures (#2172) #2175

Merged
merged 1 commit into from Apr 19, 2014

Conversation

@Manishearth
Copy link
Member

Manishearth commented Apr 18, 2014

#2172

All subtests of dom/events/Event-defaultPrevented.html pass now.

CustomEvent has yet to be implemented.(#2173)

@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Apr 18, 2014

Critic review: https://critic.hoppipolla.co.uk/r/1319

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@Ms2ger

This comment has been minimized.

Copy link

Ms2ger commented on fa7bc7a Apr 19, 2014

r+

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on fa7bc7a Apr 19, 2014

saw approval from Ms2ger
at Manishearth@fa7bc7a

This comment has been minimized.

Copy link
Contributor

bors-servo replied Apr 19, 2014

merging Manishearth/servo/domtests-createevent = fa7bc7a into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Apr 19, 2014

Manishearth/servo/domtests-createevent = fa7bc7a merged ok, testing candidate = 4331fad

This comment has been minimized.

Copy link
Contributor

bors-servo replied Apr 19, 2014

fast-forwarding master to auto = 4331fad

bors-servo pushed a commit that referenced this pull request Apr 19, 2014
#2172

All subtests of `dom/events/Event-defaultPrevented.html` pass now.

CustomEvent has yet to be implemented.(#2173)
@bors-servo bors-servo merged commit fa7bc7a into servo:master Apr 19, 2014
1 check passed
1 check passed
default all tests passed
@Manishearth Manishearth deleted the Manishearth:domtests-createevent branch Apr 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.