Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement BiquadFilterNode #21750
Implement BiquadFilterNode #21750
Conversation
highfive
commented
Sep 19, 2018
|
Heads up! This PR modifies the following files:
|
|
Looks good. Remember to update |
| DomRoot::from_ref(&self.gain) | ||
| } | ||
|
|
||
| // https://webaudio.github.io/web-audio-api/#dom-biquadfilternode-gain |
This comment has been minimized.
This comment has been minimized.
ferjm
Sep 20, 2018
Member
This comment should be https://webaudio.github.io/web-audio-api/#dom-biquadfilternode-q
| DomRoot::from_ref(&self.gain) | ||
| } | ||
|
|
||
| // https://webaudio.github.io/web-audio-api/#dom-biquadfilternode-gain |
This comment has been minimized.
This comment has been minimized.
|
@bors-servo r=ferjm |
|
|
Implement BiquadFilterNode A bunch of tests still fail but some of it may be a timing issue, looking at it the tests are *at least* affected by #21659 (changing how they work to avoid problems from that does not make them pass but does change the exact value of the error), so I feel like I should fix that first before investigating these. r? @ferjm <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21750) <!-- Reviewable:end -->
|
|
|
These seem to be more timing-related intermittents. Filing. |
|
@bors-servo retry |
|
|
|
|
Manishearth commentedSep 19, 2018
•
edited by SimonSapin
A bunch of tests still fail but some of it may be a timing issue, looking at it the tests are at least affected by #21659 (changing how they work to avoid problems from that does not make them pass but does change the exact value of the error), so I feel like I should fix that first before investigating these.
r? @ferjm
This change is