Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement missing steps for complete API #21751

Merged
merged 1 commit into from Sep 20, 2018
Merged

Implement missing steps for complete API #21751

merged 1 commit into from Sep 20, 2018

Conversation

@nupurbaghel
Copy link
Contributor

nupurbaghel commented Sep 19, 2018 •
edited by SimonSapin

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #21742
  • There are tests for these changes

This change is Reviewable
@highfive
Copy link

highfive commented Sep 19, 2018

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/htmlimageelement.rs
  • @KiChjang: components/script/dom/htmlimageelement.rs
@servo-wpt-sync servo-wpt-sync mentioned this pull request Sep 19, 2018
Open
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Sep 19, 2018

Opened new PR for upstreamable changes.

Completed upstream sync of web-platform-test changes at jdm/web-platform-tests#87.
@nupurbaghel
Copy link
Contributor Author

nupurbaghel commented Sep 19, 2018

r? @jdm
@highfive highfive assigned jdm and unassigned SimonSapin Sep 19, 2018
@jdm
Copy link
Member

jdm commented Sep 19, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Sep 19, 2018

📌 Commit b9f0060 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Sep 19, 2018

⌛ Testing commit b9f0060 with merge ebb9d85...
bors-servo added a commit that referenced this pull request Sep 19, 2018
@bors-servo
Auto merge of #21751 - nupurbaghel:complete_api, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ebb9d85 
Implement missing steps for complete API

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #21742

<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21751)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 19, 2018

💔 Test failed - linux-rel-wpt
@jdm
Copy link
Member

jdm commented Sep 20, 2018

Looks like the change to the webidl file is missing.
@bors-servo
Copy link
Contributor

bors-servo commented Sep 20, 2018

☔ The latest upstream changes (presumably #21737) made this pull request unmergeable. Please resolve the merge conflicts.
@nupurbaghel nupurbaghel force-pushed the nupurbaghel:complete_api branch from b9f0060 to af6da99 Sep 20, 2018
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Sep 20, 2018

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at jdm/web-platform-tests#87.
@nupurbaghel
implement missing steps for complete api
Loading status checks…
7ab5df1
@nupurbaghel nupurbaghel force-pushed the nupurbaghel:complete_api branch from af6da99 to 7ab5df1 Sep 20, 2018
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Sep 20, 2018

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at jdm/web-platform-tests#87.
@nupurbaghel
Copy link
Contributor Author

nupurbaghel commented Sep 20, 2018

Added the webidl :)
@jdm
Copy link
Member

jdm commented Sep 20, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Sep 20, 2018

📌 Commit 7ab5df1 has been approved by jdm
@nupurbaghel
Copy link
Contributor Author

nupurbaghel commented Sep 20, 2018

Some of the above tests like parse-a-sizes-attribute-quirks-mode.html has been showing intermittent failures after pulling changes. Should I remove them from this PR?
@bors-servo
Copy link
Contributor

bors-servo commented Sep 20, 2018

⌛ Testing commit 7ab5df1 with merge 819212e...
bors-servo added a commit that referenced this pull request Sep 20, 2018
@bors-servo
Auto merge of #21751 - nupurbaghel:complete_api, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
819212e 
Implement missing steps for complete API

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #21742

<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21751)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 20, 2018

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: jdm
Pushing 819212e to master...
@bors-servo bors-servo merged commit 7ab5df1 into servo:master Sep 20, 2018
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Sep 20, 2018

Error syncing changes upstream. Logs saved in error-snapshot-1537421878801.
This was referenced Sep 20, 2018
Merged
Closed
@jdm jdm mentioned this pull request Sep 20, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Implement missing srcset steps for HTMLImageElement's complete API
6 participants
@nupurbaghel @highfive @servo-wpt-sync @jdm @bors-servo @SimonSapin
You can’t perform that action at this time.