Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd mach command to setup remote debugging on Android devices. #21759
Conversation
highfive
commented
Sep 20, 2018
|
Heads up! This PR modifies the following files:
|
|
r? @paulrouget |
|
I get this error when trying to run mach ndk-gdb (Pixel 2). Did you have to do anything special to work around that? |
|
Ignore previous comment. Rebooting fixed my issue. |
|
Now, I get this error: On the phone, it says "Waiting for debugger". I then have to restart to prevent the |
|
Per #21768, try downloading the NDK 18 and using that when invoking the new machine command. |
|
@paulrouget Ping re: last comment. It would be great to get this into master so I can stop cherry-picking it between branches. |
|
@bors-servo r+ |
|
|
Add mach command to setup remote debugging on Android devices. This removes any need to fiddle with search paths for source files and makes the experience of remote debugging much less frustrating. I've tried this on a Pixel, Pixel 2, and emulator and successfully set breakpoints and investigated variables on all of them. The APP_ABI changes are necessary to prevent ndk-gdb from thinking that the build is arm64 when it's not. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21759) <!-- Reviewable:end -->
|
|
|
@bors-servo retry #21795 |
Add mach command to setup remote debugging on Android devices. This removes any need to fiddle with search paths for source files and makes the experience of remote debugging much less frustrating. I've tried this on a Pixel, Pixel 2, and emulator and successfully set breakpoints and investigated variables on all of them. The APP_ABI changes are necessary to prevent ndk-gdb from thinking that the build is arm64 when it's not. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21759) <!-- Reviewable:end -->
|
|
|
@bors-servo retry
|
|
|
|
|
|
@bors-servo r=paulrouget |
|
|
Add mach command to setup remote debugging on Android devices. This removes any need to fiddle with search paths for source files and makes the experience of remote debugging much less frustrating. I've tried this on a Pixel, Pixel 2, and emulator and successfully set breakpoints and investigated variables on all of them. The APP_ABI changes are necessary to prevent ndk-gdb from thinking that the build is arm64 when it's not. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21759) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
|
|
|
|
|
@bors-servo retry |
|
|
|
|
jdm commentedSep 20, 2018
•
edited by SimonSapin
This removes any need to fiddle with search paths for source files and makes the experience of remote debugging much less frustrating. I've tried this on a Pixel, Pixel 2, and emulator and successfully set breakpoints and investigated variables on all of them. The APP_ABI changes are necessary to prevent ndk-gdb from thinking that the build is arm64 when it's not.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is