Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mach command to setup remote debugging on Android devices. #21759

Merged
merged 2 commits into from Sep 25, 2018
Merged
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Next

Add mach command to setup remote debugging on Android devices.

  • Loading branch information
jdm committed Sep 25, 2018
commit 4fe41c69d327cd519d944bbddf1d893af08d6055
@@ -8,10 +8,12 @@
# except according to those terms.

from __future__ import print_function, unicode_literals
from os import path, listdir
from os import path, listdir, getcwd
from time import time

import signal
import sys
import tempfile
import urllib2
import json
import subprocess
@@ -265,3 +267,57 @@ def stack(self, release, target, logfile):
"local",
self.config["android"]["lib"])
print(subprocess.check_output([ndk_stack, "-sym", sym_path, "-dump", logfile]))

@Command('ndk-gdb',
description='Invoke ndk-gdb tool with the expected symbol paths',
category='devenv')
@CommandArgument('--release', action='store_true', help="Use release build symbols")
@CommandArgument('--target', action='store', default="armv7-linux-androideabi",
help="Build target")
def ndk_gdb(self, release, target):
env = self.build_env(target)
self.handle_android_target(target)
ndk_gdb = path.join(env["ANDROID_NDK"], "ndk-gdb")
adb_path = path.join(env["ANDROID_SDK"], "platform-tools", "adb")
sym_paths = [
path.join(
getcwd(),
"target",
target,
"release" if release else "debug",
"apk",
"obj",
"local",
self.config["android"]["lib"]
),
path.join(
getcwd(),
"target",
target,
"release" if release else "debug",
"apk",
"libs",
self.config["android"]["lib"]
),
]
env["NDK_PROJECT_PATH"] = path.join(getcwd(), "support", "android", "apk")
signal.signal(signal.SIGINT, signal.SIG_IGN)

with tempfile.NamedTemporaryFile(delete=False) as f:
f.write('\n'.join([
"python",
"param = gdb.parameter('solib-search-path')",
"param += ':{}'".format(':'.join(sym_paths)),
"gdb.execute('set solib-search-path ' + param)",
"end",
]))

p = subprocess.Popen([
ndk_gdb,
"--adb", adb_path,
"--project", "support/android/apk/servoapp/src/main/",
"--launch", "com.mozilla.servo.MainActivity",
"-x", f.name,
"--verbose",
], env=env)
return p.wait()
@@ -2,3 +2,4 @@ NDK_TOOLCHAIN_VERSION := 4.9
APP_MODULES := c++_shared servojni gstreamer
APP_PLATFORM := android-18
APP_STL:= c++_shared
APP_ABI:= armeabi-v7a x86
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.