Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable use of RUST_LOG with mach run --android. #21767

Merged
merged 1 commit into from Sep 21, 2018
Merged

Enable use of RUST_LOG with mach run --android. #21767

merged 1 commit into from Sep 21, 2018

Conversation

@jdm
Copy link
Member

jdm commented Sep 20, 2018 •
edited by SimonSapin

This allows running RUST_LOG=layout_thread ./mach run --android and seeing the appropriate logging output appear in ./adb logcat.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #21764

This change is Reviewable
@jdm
Enable use of RUST_LOG with mach run --android.
Loading status checks…
f7516f5
@highfive
Copy link

highfive commented Sep 20, 2018

Heads up! This PR modifies the following files:
@jdm
Copy link
Member Author

jdm commented Sep 20, 2018

r? @paulrouget
@highfive highfive assigned paulrouget and unassigned ferjm Sep 20, 2018
@paulrouget
Copy link
Contributor

paulrouget commented Sep 21, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Sep 21, 2018

📌 Commit f7516f5 has been approved by paulrouget
@bors-servo
Copy link
Contributor

bors-servo commented Sep 21, 2018

⌛ Testing commit f7516f5 with merge f313847...
bors-servo added a commit that referenced this pull request Sep 21, 2018
@bors-servo
Auto merge of #21767 - jdm:androidlog, r=paulrouget
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f313847 
Enable use of RUST_LOG with mach run --android.

This allows running `RUST_LOG=layout_thread ./mach run --android` and seeing the appropriate logging output appear in `./adb logcat`.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #21764

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21767)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 21, 2018

💔 Test failed - linux-rel-wpt
@jdm
Copy link
Member Author

jdm commented Sep 21, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Sep 21, 2018

⚡ Previous build results for android, android-x86, arm32, arm64, linux-dev, linux-rel-css, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only linux-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Sep 21, 2018

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: paulrouget
Pushing f313847 to master...
@bors-servo bors-servo merged commit f7516f5 into servo:master Sep 21, 2018
2 of 4 checks passed
2 of 4 checks passed
Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Sep 21, 2018
Merged
2 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@paulrouget paulrouget

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Make it easier to adjust RUST_LOG on android builds
5 participants
@jdm @highfive @paulrouget @bors-servo @ferjm
You can’t perform that action at this time.