New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite Taskcluster integration #21776

Merged
merged 160 commits into from Sep 25, 2018

Conversation

Projects
None yet
5 participants
@SimonSapin
Member

SimonSapin commented Sep 21, 2018

This rewrites this repository’s integration with Taskcluster to have a decision task that runs an in-tree Python script to schedule a graph of other tasks with inter-dependencies, saved build artifacts, Docker images built from in-tree Dockerfiles, etc. This also adds support fail daily tasks, run automatically every 24 hours. See etc/ci/taskcluster/README.md for more details.

Example of a green build with web-platform-tests enabled: https://tools.taskcluster.net/groups/aDL0pUBkSmuhezT1OF80_g

For now this PR only enables one task, equivalent to Buildbot’s linux-dev job. (Running Tidy and other linting tools, compiling in debug mode, and running unit tests.) At this time Homu does not yet block PRs from merging on a successful result from Taskcluster, but I plan to do this soon after this PR lands.


This change is Reviewable

@SimonSapin SimonSapin force-pushed the taskcluster branch from 25b000f to 685b66c Sep 24, 2018

@SimonSapin SimonSapin force-pushed the taskcluster branch from 685b66c to 6f79cad Sep 24, 2018

@SimonSapin SimonSapin force-pushed the taskcluster branch from 5571857 to ff1e8b4 Sep 24, 2018

@SimonSapin SimonSapin force-pushed the taskcluster branch from 726efec to 250236f Sep 24, 2018

@Manishearth

r=me

Could you add docstrings to all of the DecisionTask methods?

@SimonSapin SimonSapin force-pushed the taskcluster branch from 250236f to c33f5cc Sep 25, 2018

@SimonSapin

This comment has been minimized.

Member

SimonSapin commented Sep 25, 2018

Done.

@bors-servo r=Manishearth

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Sep 25, 2018

📌 Commit c33f5cc has been approved by Manishearth

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Sep 25, 2018

⌛️ Testing commit c33f5cc with merge 10cf425...

bors-servo added a commit that referenced this pull request Sep 25, 2018

Auto merge of #21776 - servo:taskcluster, r=Manishearth
Rewrite Taskcluster integration

This rewrites this repository’s integration with Taskcluster to have a decision task that runs an in-tree Python script to schedule a graph of other tasks with inter-dependencies, saved build artifacts, Docker images built from in-tree `Dockerfile`s, etc. This also adds support fail daily tasks, run automatically every 24 hours. See `etc/ci/taskcluster/README.md` for more details.

Example of a green build with web-platform-tests enabled: https://tools.taskcluster.net/groups/aDL0pUBkSmuhezT1OF80_g

For now this PR only enables one task, equivalent to Buildbot’s `linux-dev` job. (Running Tidy and other linting tools, compiling in debug mode, and running unit tests.) At this time Homu does **not** yet block PRs from merging on a successful result from Taskcluster, but I plan to do this soon after this PR lands.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21776)
<!-- Reviewable:end -->
@aneeshusa

This comment has been minimized.

Member

aneeshusa commented Sep 25, 2018

Wow, this is awesome! Didn't think you'd leap all the way to decision tasks and all on TC in one PR, super glad to see this!

@SimonSapin

This comment has been minimized.

Member

SimonSapin commented Sep 25, 2018

Yeah it took a while to figure all this out, but now we’ll hopefully be able to make further changes much more easily :)

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Sep 25, 2018

@bors-servo bors-servo merged commit c33f5cc into master Sep 25, 2018

2 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@SimonSapin SimonSapin deleted the taskcluster branch Sep 25, 2018

bors-servo added a commit to servo/saltfs that referenced this pull request Sep 25, 2018

Auto merge of #888 - servo:tc, r=jdm
Gate servo/servo PRs on Taskcluster

Taskcluster should be green since servo/servo#21776, let’s keep it that way!

CC #559

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/888)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment