Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove unnecessary define from android build. #21782
Closed
Conversation
highfive
commented
Sep 21, 2018
|
Heads up! This PR modifies the following files:
|
|
r? @asajeffrey |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Sep 21, 2018
Remove unnecessary define from android build. This regularly shows me this warning: ``` warning: In file included from <built-in>:1: warning: In file included from /Users/jdm/src/servo/target/armv7-linux-androideabi/debug/build/mozjs_sys-dd0a269b31bf3a8b/out/js/src/js-confdefs.h:91: warning: /Users/jdm/src/servo/target/armv7-linux-androideabi/debug/build/mozjs_sys-dd0a269b31bf3a8b/out/dist/include/js/RequiredDefines.h:28:9: warning: '__STDC_CONSTANT_MACROS' macro redefined [-Wmacro-redefined] warning: #define __STDC_CONSTANT_MACROS warning: ^ warning: <command line>:2:9: note: previous definition is here warning: #define __STDC_CONSTANT_MACROS 1 warning: ^ warning: 1 warning generated. ``` This was added originally before we understood the need for js-confdefs.h, but wasn't removed after our understanding grew. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21782) <!-- Reviewable:end -->
|
|
|
I stand corrected. |
|
Oh well, it was worth a try. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jdm commentedSep 21, 2018
•
edited by SimonSapin
This regularly shows me this warning:
This was added originally before we understood the need for js-confdefs.h, but wasn't removed after our understanding grew.
This change is