Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upBug 1172897 - Rename Tab Actor to BrowsingContextActor #21799
Merged
Conversation
As part of [Bug 1172987](https://bugzilla.mozilla.org/show_bug.cgi?id=1172897) we renamed TabActor, as the actor does not represent tabs (as in a browser tab), it instead represents a browsing context as defined by the the [HTML standard](https://html.spec.whatwg.org/multipage/browsers.html#windows). In a later PR I will mirror the structure we have on devtools to have a targets folder, which contains all target types. At the moment it looks like servo only represents workers and browsing contexts.
highfive
commented
Sep 24, 2018
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @avadacatavra (or someone else) soon. |
| @@ -34,7 +34,7 @@ enum AddonMsg {} | |||
| struct ListTabsReply { | |||
| from: String, | |||
| selected: u32, | |||
| tabs: Vec<TabActorMsg>, | |||
| tabs: Vec<BrowsingContextActorMsg>, | |||
This comment has been minimized.
This comment has been minimized.
codehag
Sep 24, 2018
Author
Contributor
at the moment, we still use tabs to refer to this collection in the Devtools codebase. if this changes I will update it here as well.
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 10, 2018
Bug 1172897 - Rename Tab Actor to BrowsingContextActor As part of [Bug 1172987](https://bugzilla.mozilla.org/show_bug.cgi?id=1172897) we renamed TabActor, as the actor does not represent tabs (as in a browser tab), it instead represents a browsing context as defined by the the [HTML standard](https://html.spec.whatwg.org/multipage/browsers.html#windows). In a later PR I will mirror the structure we have on devtools to have a targets folder, which contains all target types. At the moment it looks like servo only represents workers and browsing contexts. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors Unfortunately, I am unable to build due to #21792 -- I will try to find a linux machine to build on - [x] `./mach test-tidy` does not report any errors - [x] These changes fix Bugzilla [Bug 1172987](https://bugzilla.mozilla.org/show_bug.cgi?id=1172897). <!-- Either: --> - [x] These changes do not require tests because this is a renaming and shouldn't impact tests as far as I can tell <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21799) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 10, 2018
Bug 1172897 - Rename Tab Actor to BrowsingContextActor As part of [Bug 1172987](https://bugzilla.mozilla.org/show_bug.cgi?id=1172897) we renamed TabActor, as the actor does not represent tabs (as in a browser tab), it instead represents a browsing context as defined by the the [HTML standard](https://html.spec.whatwg.org/multipage/browsers.html#windows). In a later PR I will mirror the structure we have on devtools to have a targets folder, which contains all target types. At the moment it looks like servo only represents workers and browsing contexts. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors Unfortunately, I am unable to build due to #21792 -- I will try to find a linux machine to build on - [x] `./mach test-tidy` does not report any errors - [x] These changes fix Bugzilla [Bug 1172987](https://bugzilla.mozilla.org/show_bug.cgi?id=1172897). <!-- Either: --> - [x] These changes do not require tests because this is a renaming and shouldn't impact tests as far as I can tell <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21799) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
codehag commentedSep 24, 2018
•
edited by SimonSapin
As part of Bug 1172987 we renamed TabActor, as the actor does not represent tabs (as in a browser tab), it instead represents a browsing context as defined by the the HTML standard. In a later PR I will mirror the structure we have on devtools to have a targets folder, which contains all target types. At the moment it looks like servo only represents workers and browsing contexts.
./mach build -ddoes not report any errorsUnfortunately, I am unable to build due to #21792 -- I will try to find a linux machine to build on
./mach test-tidydoes not report any errorsThis change is