Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRun all webgl1 tests on android #21801
Closed
+1
−1
Conversation
highfive
commented
Sep 24, 2018
|
Heads up! This PR modifies the following files:
|
|
I am expecting... interesting... results. Also it turns out we haven't been running the existing webgl test at all since #21519. Oops. |
|
@bors-servo try=android |
bors-servo
added a commit
that referenced
this pull request
Sep 24, 2018
Run all webgl1 tests on android <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21801) <!-- Reviewable:end -->
|
|
3.6 seconds per test on average is a lot, but the number of failures is not as bad as I half-expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jdm commentedSep 24, 2018
•
edited by SimonSapin
This change is