New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Optional compositor #21808

Open
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@paulrouget
Contributor

paulrouget commented Sep 25, 2018

Early work on some refactoring of how the compositor works. Mostly to document my progress.

We want to be able to create the compositor after creating the constellation. We also want to be able to shutdown the compositor without shutting down the constellation. This will partially address #13993 and #19679.


This change is Reviewable

@highfive

This comment has been minimized.

highfive commented Sep 25, 2018

Heads up! This PR modifies the following files:

  • @asajeffrey: components/constellation/constellation.rs
  • @cbrewster: components/constellation/constellation.rs
  • @KiChjang: components/script_traits/lib.rs

@paulrouget paulrouget changed the title from [WIP] Compositor v2 to [WIP] Optional compositor Sep 25, 2018

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Sep 27, 2018

☔️ The latest upstream changes (presumably #21809) made this pull request unmergeable. Please resolve the merge conflicts.

@paulrouget

This comment has been minimized.

Contributor

paulrouget commented Oct 9, 2018

This is also necessary for Android Component where view and session are supposed to be separated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment