Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only build ports/servo by default (except Android), add `./mach build --libsimpleservo` #21809

Merged
merged 4 commits into from Sep 27, 2018

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Sep 25, 2018

Fixes #21314


This change is Reviewable

@highfive
Copy link

highfive commented Sep 25, 2018

Heads up! This PR modifies the following files:

  • @wafflespeanut: python/servo/command_base.py, python/servo/devenv_commands.py, python/servo/build_commands.py
@SimonSapin
Copy link
Member Author

SimonSapin commented Sep 25, 2018

bors-servo added a commit that referenced this pull request Sep 25, 2018
Only build ports/servo by default (except Android), add `./mach build --libsimpleservo`

Fixes #21314
@bors-servo
Copy link
Contributor

bors-servo commented Sep 25, 2018

Trying commit 8da8250 with merge d4ed7cf...

@bors-servo
Copy link
Contributor

bors-servo commented Sep 25, 2018

💔 Test failed - linux-dev

@paulrouget
Copy link
Contributor

paulrouget commented Sep 25, 2018

Can we make sure our CI keeps building libsimpleservo on at least one non-android platform?

@SimonSapin SimonSapin force-pushed the features branch from 8da8250 to 4e85f9c Sep 25, 2018
@SimonSapin
Copy link
Member Author

SimonSapin commented Sep 25, 2018

Good point, done.

@bors-servo try

@bors-servo
Copy link
Contributor

bors-servo commented Sep 25, 2018

Trying commit 4e85f9c with merge 12609d7...

bors-servo added a commit that referenced this pull request Sep 25, 2018
Only build ports/servo by default (except Android), add `./mach build --libsimpleservo`

Fixes #21314

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21809)
<!-- Reviewable:end -->
@jdm
Copy link
Member

jdm commented Sep 25, 2018

@bors-servo
Copy link
Contributor

bors-servo commented Sep 25, 2018

📌 Commit 8aed0a7 has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Sep 25, 2018

Testing commit 8aed0a7 with merge 52667cc...

bors-servo added a commit that referenced this pull request Sep 25, 2018
Only build ports/servo by default (except Android), add `./mach build --libsimpleservo`

Fixes #21314

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21809)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 25, 2018

💔 Test failed - linux-rel-css

@SimonSapin
Copy link
Member Author

SimonSapin commented Sep 26, 2018

11 timeouts out of 62 tests is rather suspicious :/ (This is the subset of the test suite run with --multiprocess.) @jdm, what do you think?

@SimonSapin
Copy link
Member Author

SimonSapin commented Sep 27, 2018

Let’s see if it happens again.

@bors-servo r- try retry

@bors-servo
Copy link
Contributor

bors-servo commented Sep 27, 2018

Trying commit deeb796 with merge 2075afb...

bors-servo added a commit that referenced this pull request Sep 27, 2018
Only build ports/servo by default (except Android), add `./mach build --libsimpleservo`

Fixes #21314

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21809)
<!-- Reviewable:end -->
@SimonSapin
Copy link
Member Author

SimonSapin commented Sep 27, 2018

jdm pointed out on IRC that the error messages included Failed to start unsandboxed child process!: Os { code: 12, kind: Other, message: "Cannot allocate memory" }, so this was likely another occurrence of remaining processes on the builder taking up RAM.

@bors-servo try- r+

(Does this command work?)

@bors-servo
Copy link
Contributor

bors-servo commented Sep 27, 2018

📌 Commit deeb796 has been approved by SimonSapin

@highfive highfive assigned SimonSapin and unassigned jdm Sep 27, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Sep 27, 2018

Testing commit deeb796 with merge 0964d05...

bors-servo added a commit that referenced this pull request Sep 27, 2018
Only build ports/servo by default (except Android), add `./mach build --libsimpleservo`

Fixes #21314

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21809)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 27, 2018

💔 Test failed - mac-rel-css2

@jdm
Copy link
Member

jdm commented Sep 27, 2018

@bors-servo
Copy link
Contributor

bors-servo commented Sep 27, 2018

@bors-servo
Copy link
Contributor

bors-servo commented Sep 27, 2018

💔 Test failed - mac-rel-css2

@jdm
Copy link
Member

jdm commented Sep 27, 2018

@bors-servo
Copy link
Contributor

bors-servo commented Sep 27, 2018

@bors-servo
Copy link
Contributor

bors-servo commented Sep 27, 2018

💔 Test failed - mac-rel-css2

@jdm
Copy link
Member

jdm commented Sep 27, 2018

@bors-servo
Copy link
Contributor

bors-servo commented Sep 27, 2018

@bors-servo
Copy link
Contributor

bors-servo commented Sep 27, 2018

@bors-servo bors-servo merged commit deeb796 into master Sep 27, 2018
2 of 4 checks passed
2 of 4 checks passed
Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@SimonSapin SimonSapin deleted the features branch Sep 28, 2018
@jdm jdm mentioned this pull request Sep 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.