Cache context attributes for the rendering context; #20532

[sumit0190]

Cache context attributes when creating webglrenderingcontext

---

• ./mach build -d does not report any errors
• ./mach test-tidy does not report any errors
• These changes fix #20532 (github issue number if applicable).

• There are tests for these changes OR
• These changes do not require tests because there's no direct way to test it.

---

This change is 

[ghost]

No Taskcluster jobs started for this pull request

The `allowPullRequests` configuration for this repository (in `.taskcluster.yml` on the
default branch) does not allow starting tasks for this pull request.

[highfive]

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @asajeffrey (or someone else) soon.

[highfive]

Heads up! This PR modifies the following files:

• @asajeffrey: components/script/dom/webglrenderingcontext.rs
• @KiChjang: components/script/dom/webglrenderingcontext.rs

[highfive]

Warning

• These commits modify script code, but no tests are modified. Please consider adding a test!

[CYBAI]

Maybe you won't need return here? Also, it would be great to indent one more tab inside the function!

fn GetContextAttributes(&self) -> Option<WebGLContextAttributes> {
    // Currently ...
    Some(WebGLContextAttributes {
        ...
    })
}

[sumit0190]

Will do; just gonna wait for some other feedback and bundle up the changes if possible.

[nox]

Why not just return self.attrs?

[sumit0190]

Borrow checker doesn't like that. I also can't use clone here, I literally have to create a new object.

[bors-servo]

☔ The latest upstream changes (presumably #21825) made this pull request unmergeable. Please resolve the merge conflicts.

[asajeffrey]

@sumit0190 Are you still working on this?

[asajeffrey]

@sumit0190 Ping?

[sumit0190]

Sorry about that; I missed the earlier ping completely.

I'll check if the PR is still valid - not sure if the comments I added are still true or not (haven't been keeping up with all the changes).

[asajeffrey]

@sumit0190 another ping?

[asajeffrey]

I'll close this for now, but feel free to reopen it!