New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional backtraces for JS errors and WebGL errors #21825

Merged
merged 2 commits into from Oct 2, 2018

Conversation

Projects
None yet
6 participants
@jdm
Member

jdm commented Sep 27, 2018

This adds two new build-time features to enable useful debugging tools when investigating why JS and WebGL content isn't working. They're optional because they're quite heavyweight.


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes do not require tests because they're optional developer features.

This change is Reviewable

@highfive

This comment has been minimized.

highfive commented Sep 27, 2018

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webglrenderingcontext.rs, components/script/Cargo.toml, components/script/dom/bindings/error.rs, components/script/lib.rs
  • @paulrouget: ports/servo/Cargo.toml, components/servo/Cargo.toml
  • @KiChjang: components/script/dom/webglrenderingcontext.rs, components/script/Cargo.toml, components/script/dom/bindings/error.rs, components/script/lib.rs
@highfive

This comment has been minimized.

highfive commented Sep 27, 2018

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify script code, but no tests are modified. Please consider adding a test!

@jdm jdm force-pushed the jdm:backtrace-helpers branch from 5f6aaf5 to bc2dce9 Sep 27, 2018

@Manishearth

This comment has been minimized.

Member

Manishearth commented Sep 27, 2018

r=me

@jdm jdm force-pushed the jdm:backtrace-helpers branch from bc2dce9 to e42b122 Oct 1, 2018

@jdm

This comment has been minimized.

Member

jdm commented Oct 1, 2018

@bors-servo r=Manishearth

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 1, 2018

📌 Commit e42b122 has been approved by Manishearth

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 1, 2018

⌛️ Testing commit e42b122 with merge a1d5efd...

bors-servo added a commit that referenced this pull request Oct 1, 2018

Auto merge of #21825 - jdm:backtrace-helpers, r=Manishearth
Optional backtraces for JS errors and WebGL errors

This adds two new build-time features to enable useful debugging tools when investigating why JS and WebGL content isn't working. They're optional because they're quite heavyweight.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes do not require tests because they're optional developer features.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21825)
<!-- Reviewable:end -->
@nox

This comment has been minimized.

Member

nox commented Oct 1, 2018

There is no description of the changes, and this doesn't add documentation that the feature even exists.

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 1, 2018

💔 Test failed - linux-rel-wpt

@jdm jdm force-pushed the jdm:backtrace-helpers branch from e42b122 to 06bca43 Oct 1, 2018

@jdm

This comment has been minimized.

Member

jdm commented Oct 1, 2018

@nox I have added configuration flags to servobuild.example that describe what they do. Does that address your concerns?

@nox

This comment has been minimized.

Member

nox commented Oct 2, 2018

Yes!

@jdm

This comment has been minimized.

Member

jdm commented Oct 2, 2018

@bors-servo r=Manishearth

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 2, 2018

📌 Commit 06bca43 has been approved by Manishearth

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 2, 2018

⌛️ Testing commit 06bca43 with merge 57053e0...

bors-servo added a commit that referenced this pull request Oct 2, 2018

Auto merge of #21825 - jdm:backtrace-helpers, r=Manishearth
Optional backtraces for JS errors and WebGL errors

This adds two new build-time features to enable useful debugging tools when investigating why JS and WebGL content isn't working. They're optional because they're quite heavyweight.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes do not require tests because they're optional developer features.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21825)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 2, 2018

💔 Test failed - linux-rel-wpt

@jdm

This comment has been minimized.

Member

jdm commented Oct 2, 2018

@bors-servo retry

  • oom
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 2, 2018

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 2, 2018

@bors-servo bors-servo merged commit 06bca43 into servo:master Oct 2, 2018

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment