Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upEnable fake fillText API in nightly builds. #21826
Conversation
|
The other option would be enabling this fake API for all builds via prefs.json, not just nightly builds. |
|
I changed my mind - it will possibly be even more confusing to have the examples work in nightly builds and not in local builds. I think we should just accept the fact that this API is required by high priority test files and enable it. |
|
I’m not really happy with exposing non-implemented features, but I understand that this fixes an immediate problem. r=me with an issue filed to track having a separate set of prefs for local and Nightly builds v.s. Release, or whatever we call the builds we ship to distributions like Play Store. |
|
Filed #21837 and added it to the |
|
@bors-servo r=SimonSapin |
|
|
Enable fake fillText API in nightly builds. The [three.js examples](https://threejs.org/examples/) are really useful for checking Servo WebGL support, but if the fillText API is not available they only display a blank screen. I think it's worth lying to web content about this API in order to make it easy to make use of these examples without using local development builds. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21826) <!-- Reviewable:end -->
|
|
|
@bors-servo r=SimonSapin |
|
|
Enable fake fillText API in nightly builds. The [three.js examples](https://threejs.org/examples/) are really useful for checking Servo WebGL support, but if the fillText API is not available they only display a blank screen. I think it's worth lying to web content about this API in order to make it easy to make use of these examples without using local development builds. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21826) <!-- Reviewable:end -->
|
|
|
@bors-servo r=SimonSapin |
|
|
Enable fake fillText API in nightly builds. The [three.js examples](https://threejs.org/examples/) are really useful for checking Servo WebGL support, but if the fillText API is not available they only display a blank screen. I think it's worth lying to web content about this API in order to make it easy to make use of these examples without using local development builds. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21826) <!-- Reviewable:end -->
|
|
|
@bors-servo r+ |
|
|
Enable fake fillText API in nightly builds. The [three.js examples](https://threejs.org/examples/) are really useful for checking Servo WebGL support, but if the fillText API is not available they only display a blank screen. I think it's worth lying to web content about this API in order to make it easy to make use of these examples without using local development builds. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21826) <!-- Reviewable:end -->
|
|
jdm commentedSep 27, 2018
•
edited by SimonSapin
The three.js examples are really useful for checking Servo WebGL support, but if the fillText API is not available they only display a blank screen. I think it's worth lying to web content about this API in order to make it easy to make use of these examples without using local development builds.
This change is