Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: com.mozilla to org.mozilla #21830

Merged
merged 1 commit into from Oct 2, 2018
Merged

Android: com.mozilla to org.mozilla #21830

merged 1 commit into from Oct 2, 2018

Conversation

@paulrouget
Copy link
Contributor

paulrouget commented Sep 28, 2018

We want to be compatible with the GeckoView namespace: https://maven.mozilla.org/maven2?prefix=maven2/org/mozilla/


This change is Reviewable

@highfive
Copy link

highfive commented Sep 28, 2018

Heads up! This PR modifies the following files:

  • @wafflespeanut: python/servo/devenv_commands.py, python/servo/post_build_commands.py
@SimonSapin
Copy link
Member

SimonSapin commented Sep 28, 2018

I’ve only skimmed the diff but it seems straightforward enough.

@bors-servo r+

@bors-servo
Copy link
Contributor

bors-servo commented Sep 28, 2018

📌 Commit 3a47b8f has been approved by SimonSapin

@bors-servo
Copy link
Contributor

bors-servo commented Sep 28, 2018

Testing commit 3a47b8f with merge fa42029...

bors-servo added a commit that referenced this pull request Sep 28, 2018
Android: com.mozilla to org.mozilla

We want to be compatible with the GeckoView namespace: https://maven.mozilla.org/maven2?prefix=maven2/org/mozilla/

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21830)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 28, 2018

💔 Test failed - mac-rel-wpt2

@jdm
Copy link
Member

jdm commented Sep 28, 2018

@bors-servo
Copy link
Contributor

bors-servo commented Sep 28, 2018

Testing commit 3a47b8f with merge af2eb9a...

bors-servo added a commit that referenced this pull request Sep 28, 2018
Android: com.mozilla to org.mozilla

We want to be compatible with the GeckoView namespace: https://maven.mozilla.org/maven2?prefix=maven2/org/mozilla/

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21830)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 28, 2018

💔 Test failed - mac-rel-css2

@jdm
Copy link
Member

jdm commented Sep 28, 2018

@bors-servo
Copy link
Contributor

bors-servo commented Sep 28, 2018

@bors-servo
Copy link
Contributor

bors-servo commented Sep 28, 2018

💔 Test failed - mac-rel-css2

@jdm
Copy link
Member

jdm commented Sep 28, 2018

@bors-servo
Copy link
Contributor

bors-servo commented Sep 28, 2018

Testing commit 3a47b8f with merge 0891ef7...

bors-servo added a commit that referenced this pull request Sep 28, 2018
Android: com.mozilla to org.mozilla

We want to be compatible with the GeckoView namespace: https://maven.mozilla.org/maven2?prefix=maven2/org/mozilla/

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21830)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 28, 2018

💔 Test failed - status-taskcluster

@jdm
Copy link
Member

jdm commented Sep 28, 2018

+ ./etc/ci/bootstrap-android-and-accept-licences.sh
[taskcluster 2018-09-28 17:34:06.740Z] === Task Finished ===
[taskcluster 2018-09-28 17:34:06.743Z] Artifact "public/servoapp.apk" not found at "/repo/target/armv7-linux-androideabi/release/servoapp.apk"
[taskcluster 2018-09-28 17:34:06.744Z] Artifact "public/servoview.aar" not found at "/repo/target/armv7-linux-androideabi/release/servoview.aar"
[taskcluster 2018-09-28 17:34:07.132Z] Unsuccessful task run with exit code: 137 completed in 24.347 seconds
@jdm
Copy link
Member

jdm commented Sep 28, 2018

The log looks like it didn't even bother executing ./mach build --android; I'm not really clear what's going on.

@jdm
Copy link
Member

jdm commented Sep 28, 2018

@SimonSapin Is the new android task operating correctly? I'm not sure how to interpret that log.

@SimonSapin
Copy link
Member

SimonSapin commented Sep 28, 2018

The task’s script is executed with bash -e, so if any command fail the script will stop there and fail. So bootstrap-android-and-accept-licences.sh likely exited with a non-zero status code, but I don’t know why it didn’t produce any output…

@bors-servo
Copy link
Contributor

bors-servo commented Oct 1, 2018

The latest upstream changes (presumably #21848) made this pull request unmergeable. Please resolve the merge conflicts.

@paulrouget paulrouget force-pushed the paulrouget:com2org branch from 3a47b8f to 6d543de Oct 2, 2018
@paulrouget
Copy link
Contributor Author

paulrouget commented Oct 2, 2018

Rebased.

@bors-servo r=SimonSapin

@bors-servo
Copy link
Contributor

bors-servo commented Oct 2, 2018

📌 Commit 6d543de has been approved by SimonSapin

@bors-servo
Copy link
Contributor

bors-servo commented Oct 2, 2018

Testing commit 6d543de with merge 37b978a...

bors-servo added a commit that referenced this pull request Oct 2, 2018
Android: com.mozilla to org.mozilla

We want to be compatible with the GeckoView namespace: https://maven.mozilla.org/maven2?prefix=maven2/org/mozilla/

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21830)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 2, 2018

💔 Test failed - mac-rel-wpt2

@CYBAI
Copy link
Collaborator

CYBAI commented Oct 2, 2018

@bors-servo retry

{"status": "FAIL", "group": "default", "message": "assert_array_equals: Pages opened during history navigation property 2, expected 2 but got 3", "stack": "start_test_wait</check_result<@http://web-platform.test:8000/html/browsers/history/the-history-interface/traverse_the_history_write_after_load_1.html:19:11\nTest.prototype.step@http://web-platform.test:8000/resources/testharness.js:1561:20\nTest.prototype.step_func/<@http://web-platform.test:8000/resources/testharness.js:1585:20\n", "subtest": "Traverse the history after document.write after the load event", "test": "/html/browsers/history/the-history-interface/traverse_the_history_write_after_load_1.html", "line": 15892, "action": "test_result", "expected": "TIMEOUT"}
{"status": "OK", "group": "default", "message": null, "stack": null, "subtest": null, "test": "/html/browsers/history/the-history-interface/traverse_the_history_write_after_load_1.html", "line": 15893, "action": "test_result", "expected": "TIMEOUT"}
@bors-servo
Copy link
Contributor

bors-servo commented Oct 2, 2018

@bors-servo bors-servo merged commit 6d543de into servo:master Oct 2, 2018
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
FxR / Servo / Immersive Mode automation moved this from Todo to Done Oct 2, 2018
@bors-servo bors-servo mentioned this pull request Oct 2, 2018
4 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.