Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix appveyor build #21833

Merged
merged 1 commit into from Oct 1, 2018
Merged

Fix appveyor build #21833

merged 1 commit into from Oct 1, 2018

Conversation

@jdm
Copy link
Member

jdm commented Sep 28, 2018

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #21832
  • There are tests for these changes

This change is Reviewable

@highfive
Copy link

highfive commented Sep 28, 2018

Heads up! This PR modifies the following files:

@SimonSapin
Copy link
Member

SimonSapin commented Oct 1, 2018

@bors-servo
Copy link
Contributor

bors-servo commented Oct 1, 2018

📌 Commit 48a16ac has been approved by SimonSapin

@bors-servo
Copy link
Contributor

bors-servo commented Oct 1, 2018

Testing commit 48a16ac with merge 4205ff9...

bors-servo added a commit that referenced this pull request Oct 1, 2018
Fix appveyor build

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #21832
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21833)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 1, 2018

@bors-servo bors-servo merged commit 48a16ac into master Oct 1, 2018
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
homu Test successful
Details
@SimonSapin SimonSapin deleted the jdm-patch-37 branch Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can’t perform that action at this time.