Create a Maven repository on package #21851

paulrouget · 2018-10-02T13:34:06Z

This new step will go through all the release builds of the servoview AAR, and create a maven repo (just a tree of directories) with the relevant POM files under target/gradle/servoview/maven.

For example, after building for armv7 and x86, it looks like this:

/Users/paul/git/servo/target/gradle/servoview/maven
└── org
    └── mozilla
        └── servoview
            ├── servoview-armv7
            │   ├── 0.0.1.20181002
            │   │   ├── servoview-armv7-0.0.1.20181002.aar
            │   │   ├── servoview-armv7-0.0.1.20181002.aar.md5
            │   │   ├── servoview-armv7-0.0.1.20181002.aar.sha1
            │   │   ├── servoview-armv7-0.0.1.20181002.pom
            │   │   ├── servoview-armv7-0.0.1.20181002.pom.md5
            │   │   └── servoview-armv7-0.0.1.20181002.pom.sha1
            │   ├── maven-metadata.xml
            │   ├── maven-metadata.xml.md5
            │   └── maven-metadata.xml.sha1
            └── servoview-x86
                ├── 0.0.1.20181002
                │   ├── servoview-x86-0.0.1.20181002.aar
                │   ├── servoview-x86-0.0.1.20181002.aar.md5
                │   ├── servoview-x86-0.0.1.20181002.aar.sha1
                │   ├── servoview-x86-0.0.1.20181002.pom
                │   ├── servoview-x86-0.0.1.20181002.pom.md5
                │   └── servoview-x86-0.0.1.20181002.pom.sha1
                ├── maven-metadata.xml
                ├── maven-metadata.xml.md5
                └── maven-metadata.xml.sha1

This change is

paulrouget · 2018-10-02T13:42:53Z

@MortimerGoro r?

MortimerGoro · 2018-10-02T14:01:37Z

support/android/apk/servoview/build.gradle

+
+uploadArchives {
+  doFirst {
+      for ( arch in ["arm", "armv7", "arm64", "x86"] ) {


We can drop normal "arm", it's already deprecated. There aren't Android 4+ devices which support armeabi but not armeabi-v7a, so we can safely drop armeabi and save some compilation work & upload bandwidth. We can remove armeabi also from Servo cloud compilation tests if it's still there.

Other than that code looks good ;)

jdm · 2018-10-02T14:04:59Z

What if we add a new flag to the package command to cause the maven generation to happen? Is it common to want a maven repo for local release builds?

MortimerGoro · 2018-10-02T14:11:52Z

support/android/apk/servoview/build.gradle

+    }
+    repositories.mavenDeployer {
+        repository(url: "file://localhost/${buildDir}/maven")
+        def version = "0.0.1." + new Date().format('yyyyMMdd')


There may be collisions if we deploy 2 builds on the same day. It may be a good idea to add a commit id abbreviation to the end to avoid conflicts and be able to link the build to a specific commit

MortimerGoro · 2018-10-02T14:19:23Z

yes, we should add something as a package flag to make this optional, it shouldn't upload to maven by default on a local package command or PR automatic testing.

Are we going to deploy on every commit to servo master? on the Gecko android side they only deploy when inbound is merged to central. Is there a similar grouping on Servo to publish the nightly snapshots?

paulrouget · 2018-10-02T14:43:28Z

We can drop normal "arm"

I'll file a follow-up issue for that. This requires changes that are beyond this PR.

Edit: issue #21854

paulrouget · 2018-10-02T14:49:10Z

This change doesn't upload/deploy anything. It only creates the Maven directory structure that can be re-use locally by other projects.

Before this PR, the AAR would be copied to target/XXX/servoview.aar, now it's also copied under target/gradle/servoview/maven, alongside the POM file. That's it.

So far, third party projects do not use a local maven repo but a direct link to the AAR (servoviewLocal in user.properties). It's convenient and easy, we're going to keep it that way.

I will add a flag to create the maven repo.

paulrouget · 2018-10-02T16:02:39Z

I added a flag: mach package --android --maven.

To deploy, build with --android, package with --android and --maven, and upload/rsync target/gradle/servoview/maven.

Note: if a x86 build is present along armv7, this will also package the x86 aar.


        Create a Maven repository

paulrouget · 2018-10-02T16:17:29Z

@MortimerGoro r?

paulrouget · 2018-10-03T00:58:41Z

@bors-servo r=MortimerGoro

bors-servo · 2018-10-03T00:58:41Z

📌 Commit 54d7788 has been approved by MortimerGoro

bors-servo · 2018-10-03T00:58:48Z

⌛ Testing commit 54d7788 with merge 021a24d...


        Auto merge of #21851 - paulrouget:maven, r=MortimerGoro

Create a Maven repository on package This new step will go through all the *release* builds of the servoview AAR, and create a maven repo (just a tree of directories) with the relevant POM files under `target/gradle/servoview/maven`. For example, after building for armv7 and x86, it looks like this: ``` /Users/paul/git/servo/target/gradle/servoview/maven └── org └── mozilla └── servoview ├── servoview-armv7 │ ├── 0.0.1.20181002 │ │ ├── servoview-armv7-0.0.1.20181002.aar │ │ ├── servoview-armv7-0.0.1.20181002.aar.md5 │ │ ├── servoview-armv7-0.0.1.20181002.aar.sha1 │ │ ├── servoview-armv7-0.0.1.20181002.pom │ │ ├── servoview-armv7-0.0.1.20181002.pom.md5 │ │ └── servoview-armv7-0.0.1.20181002.pom.sha1 │ ├── maven-metadata.xml │ ├── maven-metadata.xml.md5 │ └── maven-metadata.xml.sha1 └── servoview-x86 ├── 0.0.1.20181002 │ ├── servoview-x86-0.0.1.20181002.aar │ ├── servoview-x86-0.0.1.20181002.aar.md5 │ ├── servoview-x86-0.0.1.20181002.aar.sha1 │ ├── servoview-x86-0.0.1.20181002.pom │ ├── servoview-x86-0.0.1.20181002.pom.md5 │ └── servoview-x86-0.0.1.20181002.pom.sha1 ├── maven-metadata.xml ├── maven-metadata.xml.md5 └── maven-metadata.xml.sha1 ```  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21851)

bors-servo · 2018-10-03T02:03:57Z

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, status-taskcluster, windows-msvc-dev
Approved by: MortimerGoro
Pushing 021a24d to master...

paulrouget changed the title ~~Create a Maven repository on build~~ Create a Maven repository on package Oct 2, 2018

paulrouget added this to Todo in FxR / Servo / Immersive Mode Oct 2, 2018

MortimerGoro reviewed Oct 2, 2018

View changes

paulrouget mentioned this pull request Oct 2, 2018

Drop support for Arm (Armv7 should be default) #21854

Open

paulrouget force-pushed the paulrouget:maven branch from 3e3dfa3 to 2368502 Oct 2, 2018

highfive added the S-awaiting-review label Oct 2, 2018

paulrouget force-pushed the paulrouget:maven branch from 2368502 to 036a527 Oct 2, 2018

Create a Maven repository

Loading status checks…

54d7788

paulrouget force-pushed the paulrouget:maven branch from 036a527 to 54d7788 Oct 2, 2018

MortimerGoro approved these changes Oct 2, 2018

View changes

highfive assigned MortimerGoro Oct 3, 2018

highfive added S-awaiting-merge and removed S-awaiting-review labels Oct 3, 2018

FxR / Servo / Immersive Mode automation moved this from Todo to Done Oct 3, 2018

highfive removed the S-awaiting-merge label Oct 3, 2018

servo / servo

Create a Maven repository on package #21851

Create a Maven repository on package #21851

paulrouget commented Oct 2, 2018 •

edited by SimonSapin

paulrouget commented Oct 2, 2018

This comment has been minimized.

This comment has been minimized.

jdm commented Oct 2, 2018

This comment has been minimized.

This comment has been minimized.

MortimerGoro commented Oct 2, 2018 •

edited

paulrouget commented Oct 2, 2018 •

edited

paulrouget commented Oct 2, 2018

paulrouget commented Oct 2, 2018

paulrouget commented Oct 2, 2018

paulrouget commented Oct 3, 2018

bors-servo commented Oct 3, 2018

bors-servo commented Oct 3, 2018

bors-servo commented Oct 3, 2018

servo / servo

Join GitHub today

Create a Maven repository on package #21851

Create a Maven repository on package #21851

Conversation

paulrouget commented Oct 2, 2018 • edited by SimonSapin

paulrouget commented Oct 2, 2018

This comment has been minimized.

MortimerGoro Oct 2, 2018

This comment has been minimized.

MortimerGoro Oct 2, 2018

jdm commented Oct 2, 2018

This comment has been minimized.

MortimerGoro Oct 2, 2018

This comment has been minimized.

paulrouget Oct 2, 2018

MortimerGoro commented Oct 2, 2018 • edited

paulrouget commented Oct 2, 2018 • edited

paulrouget commented Oct 2, 2018

paulrouget commented Oct 2, 2018

paulrouget commented Oct 2, 2018

paulrouget commented Oct 3, 2018

bors-servo commented Oct 3, 2018

bors-servo commented Oct 3, 2018

bors-servo commented Oct 3, 2018

paulrouget commented Oct 2, 2018 •

edited by SimonSapin

MortimerGoro commented Oct 2, 2018 •

edited

paulrouget commented Oct 2, 2018 •

edited