Update GStreamer binaries for Android. Include required codecs #21864

ferjm · 2018-10-03T12:31:28Z

./mach build -d does not report any errors
./mach test-tidy does not report any errors

This should finally work for both armv7 and x86. I moved the binaries from Github to S3.

This change is

highfive · 2018-10-03T12:31:32Z

Heads up! This PR modifies the following files:

@wafflespeanut: python/servo/build_commands.py

ferjm · 2018-10-03T12:33:24Z

@bors-servo try

bors-servo · 2018-10-03T12:33:31Z

⌛ Trying commit d303d79 with merge 55262b6...


        Auto merge of #21864 - ferjm:android.gst.binaries.update, r=<try>

Update GStreamer binaries for Android. Include required codecs - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors This should finally work for both armv7 and x86. I moved the binaries from Github to S3. I also updated the build scripts and [documented the workaround for the issue](servo/libgstreamer_android_gen@da2d89a) that I was hitting when building for x86.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21864)

bors-servo · 2018-10-03T13:07:40Z

💔 Test failed - status-taskcluster

SimonSapin · 2018-10-03T14:37:44Z

error: failed to run custom build command for `servo-media-gstreamer v0.1.0 (https://github.com/servo/media#e700a083)`
process didn't exit successfully: `/repo/target/release/build/servo-media-gstreamer-c45c9a207b7ec1ad/build-script-build` (exit code: 101)
--- stderr
--2018-10-03 13:06:21--  https://github.com/servo/libgstreamer_android_gen/blob/master/out/gst-build-armeabi-v7a.zip?raw=true
Resolving github.com (github.com)... 192.30.255.112, 192.30.255.113
Connecting to github.com (github.com)|192.30.255.112|:443... connected.
HTTP request sent, awaiting response... 404 Not Found

SimonSapin · 2018-10-03T16:20:15Z

#21863 also failed its android-x86 job with:

Downloading GStreamer dependencies
Error running mach:

    ['build', '--target', 'i686-linux-android', '--release']

The error occurred in the implementation of the invoked mach command.

This should never occur and is likely a bug in the implementation of that
command. Consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

OSError: [Errno 2] No such file or directory: '/home/servo/buildbot/slave/android-x86/build/target/gstreamer/gst-build-x86/pkgconfig'

  File "/home/servo/buildbot/slave/android-x86/build/python/servo/build_commands.py", line 436, in build
    for each in os.listdir(pkg_config_path):

bors-servo · 2018-10-03T16:20:25Z

☔ The latest upstream changes (presumably #21865) made this pull request unmergeable. Please resolve the merge conflicts.

ferjm · 2018-10-08T14:08:51Z

@bors-servo try

bors-servo · 2018-10-08T14:08:56Z

⌛ Trying commit 4780876 with merge 7b13415...


        Auto merge of #21864 - ferjm:android.gst.binaries.update, r=<try>

Update GStreamer binaries for Android. Include required codecs - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors This should finally work for both armv7 and x86. I moved the binaries from Github to S3. I also updated the build scripts and [documented the workaround for the issue](servo/libgstreamer_android_gen@da2d89a) that I was hitting when building for x86.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21864)

bors-servo · 2018-10-08T14:14:28Z

💔 Test failed - android

ferjm · 2018-10-08T14:15:58Z

@bors-servo retry

bors-servo · 2018-10-08T14:16:03Z

⌛ Trying commit 4780876 with merge c951f6c...


        Auto merge of #21864 - ferjm:android.gst.binaries.update, r=<try>

Update GStreamer binaries for Android. Include required codecs - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors This should finally work for both armv7 and x86. I moved the binaries from Github to S3. I also updated the build scripts and [documented the workaround for the issue](servo/libgstreamer_android_gen@da2d89a) that I was hitting when building for x86.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21864)

bors-servo · 2018-10-08T15:53:27Z

💔 Test failed - mac-rel-wpt1

jdm · 2018-10-08T15:54:54Z

That was caused by me messing with that builder to deploy servo/saltfs#898. The other mac builds were fine.

ferjm · 2018-10-08T15:58:44Z

r? @SimonSapin

SimonSapin · 2018-10-30T07:33:44Z

My Unicode-in-Python-2 must be… rusty. I’m honestly confused why we get a decode error in encode() called by the write() method of what should be a byte stream, called with what should be bytes.

ferjm · 2018-11-02T12:18:02Z

@bors-servo try=android

bors-servo · 2018-11-02T12:18:08Z

⌛ Trying commit 66d6dd7 with merge 73b02b2...


        Auto merge of #21864 - ferjm:android.gst.binaries.update, r=<try>

Update GStreamer binaries for Android. Include required codecs - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors This should finally work for both armv7 and x86. I moved the binaries from Github to S3.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21864)

ferjm · 2018-11-02T12:47:41Z

@bors-servo try=android

bors-servo · 2018-11-02T12:47:46Z

⌛ Trying commit 203fb1d with merge 51480ed...


        Auto merge of #21864 - ferjm:android.gst.binaries.update, r=<try>

Update GStreamer binaries for Android. Include required codecs - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors This should finally work for both armv7 and x86. I moved the binaries from Github to S3.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21864)

bors-servo · 2018-11-02T13:30:55Z

💔 Test failed - android-x86

ferjm · 2018-11-02T16:12:24Z

I managed to reproduce the issue locally by regenerating the binaries again (I am not sure why I wasn't able to reproduce it before... :). I got this from the logcat:

"/data/app/org.mozilla.servo-nOOw72Qz41OjUAUw_uVE7g==/lib/x86/libgstreamer_android.so" has text relocations (https://android.googlesource.com/platform/bionic/+/master/android-changes-for-ndk-developers.md#Text-Relocations-Enforced-for-API-level-23)
--------- beginning of crash
FATAL EXCEPTION: GLThread 285
Process: org.mozilla.servo, PID: 4791
java.lang.UnsatisfiedLinkError: dlopen failed: "/data/app/org.mozilla.servo-nOOw72Qz41OjUAUw_uVE7g==/lib/x86/libgstreamer_android.so" has text relocations (https://android.googlesource.com/platform/bionic/+/master/android-changes-for-ndk-developers.md#Text-Relocations-Enforced-for-API-level-23)
	at java.lang.Runtime.loadLibrary0(Runtime.java:1016)
	at java.lang.System.loadLibrary(System.java:1669)
	at org.mozilla.servoview.JNIServo.<init>(JNIServo.java:17)
	at org.mozilla.servoview.Servo.<init>(Servo.java:22)
	at org.mozilla.servoview.ServoView.lambda$onGLReady$1$ServoView(ServoView.java:152)
	at org.mozilla.servoview.ServoView$$Lambda$1.run(Unknown Source:4)
	at android.opengl.GLSurfaceView$GLThread.guardedRun(GLSurfaceView.java:1500)
	at android.opengl.GLSurfaceView$GLThread.run(GLSurfaceView.java:1270)
  Force finishing activity org.mozilla.servo/.MainActivity

Which lead me to this known and unresolved GStreamer issue https://bugzilla.gnome.org/show_bug.cgi?id=742633

I don't think we need the x86 emulator to playback a/v video any time soon. So in order to unblock a/v playback on real devices, I am going to temporarily remove libav from the x86 binaries.


        Update GStreamer binaries for Android. Include required codecs

ferjm · 2018-11-05T13:36:17Z

@bors-servo try=android

bors-servo · 2018-11-05T13:36:22Z

⌛ Trying commit fb28cc7 with merge 3f4e108...


        Auto merge of #21864 - ferjm:android.gst.binaries.update, r=<try>

Update GStreamer binaries for Android. Include required codecs - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors This should finally work for both armv7 and x86. I moved the binaries from Github to S3.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21864)

bors-servo · 2018-11-05T14:00:33Z

☀️ Test successful - android, android-mac, android-x86
State: approved= try=True

ferjm · 2018-11-05T14:10:16Z

I've documented the workaround at https://github.com/servo/libgstreamer_android_gen/blob/536676168014b60d59ce8a0d1ef4003632d9c941/README.md#known-issues

ferjm · 2018-11-05T14:11:11Z

@bors-servo r=SimonSapin

bors-servo · 2018-11-05T14:11:12Z

📌 Commit fb28cc7 has been approved by SimonSapin

bors-servo · 2018-11-05T14:11:17Z

⌛ Testing commit fb28cc7 with merge 8205575...


        Auto merge of #21864 - ferjm:android.gst.binaries.update, r=SimonSapin

Update GStreamer binaries for Android. Include required codecs - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors This should finally work for both armv7 and x86. I moved the binaries from Github to S3.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21864)

bors-servo · 2018-11-05T15:27:36Z

☀️ Test successful - android, android-mac, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, status-taskcluster, windows-msvc-dev
Approved by: SimonSapin
Pushing 8205575 to master...

highfive assigned asajeffrey Oct 3, 2018

highfive added the S-awaiting-review label Oct 3, 2018

highfive added the S-tests-failed label Oct 3, 2018

CYBAI mentioned this pull request Oct 3, 2018

Update the influent crate from 0.4.0 to 0.4.1 #21865

Merged

highfive added the S-needs-rebase label Oct 3, 2018

ferjm force-pushed the ferjm:android.gst.binaries.update branch from d303d79 to d7e9437 Oct 8, 2018

highfive removed the S-tests-failed label Oct 8, 2018

ferjm force-pushed the ferjm:android.gst.binaries.update branch from d7e9437 to 4780876 Oct 8, 2018

ferjm removed the S-needs-rebase label Oct 8, 2018

highfive added the S-tests-failed label Oct 8, 2018

highfive assigned SimonSapin and unassigned asajeffrey Oct 8, 2018

highfive added the S-tests-failed label Oct 30, 2018

highfive removed the S-tests-failed label Nov 2, 2018

highfive added the S-tests-failed label Nov 2, 2018

Update GStreamer binaries for Android. Include required codecs

Loading status checks…

fb28cc7

ferjm force-pushed the ferjm:android.gst.binaries.update branch from 203fb1d to fb28cc7 Nov 5, 2018

highfive removed the S-tests-failed label Nov 5, 2018

highfive added S-awaiting-merge and removed S-awaiting-review labels Nov 5, 2018

bors-servo merged commit fb28cc7 into servo:master Nov 5, 2018
3 checks passed

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

highfive removed the S-awaiting-merge label Nov 5, 2018

ferjm deleted the ferjm:android.gst.binaries.update branch Nov 5, 2018

servo / servo

Update GStreamer binaries for Android. Include required codecs #21864

Update GStreamer binaries for Android. Include required codecs #21864

ferjm commented Oct 3, 2018 •

edited

highfive commented Oct 3, 2018

ferjm commented Oct 3, 2018

bors-servo commented Oct 3, 2018

bors-servo commented Oct 3, 2018

SimonSapin commented Oct 3, 2018

SimonSapin commented Oct 3, 2018

bors-servo commented Oct 3, 2018

ferjm commented Oct 8, 2018

bors-servo commented Oct 8, 2018

bors-servo commented Oct 8, 2018

ferjm commented Oct 8, 2018

bors-servo commented Oct 8, 2018

bors-servo commented Oct 8, 2018

jdm commented Oct 8, 2018

ferjm commented Oct 8, 2018

SimonSapin commented Oct 30, 2018

ferjm commented Nov 2, 2018

bors-servo commented Nov 2, 2018

ferjm commented Nov 2, 2018

bors-servo commented Nov 2, 2018

bors-servo commented Nov 2, 2018

ferjm commented Nov 2, 2018

ferjm commented Nov 5, 2018

bors-servo commented Nov 5, 2018

bors-servo commented Nov 5, 2018

ferjm commented Nov 5, 2018

ferjm commented Nov 5, 2018

bors-servo commented Nov 5, 2018

bors-servo commented Nov 5, 2018

bors-servo commented Nov 5, 2018

servo / servo

Join GitHub today

Update GStreamer binaries for Android. Include required codecs #21864

Update GStreamer binaries for Android. Include required codecs #21864

Conversation

ferjm commented Oct 3, 2018 • edited

highfive commented Oct 3, 2018

ferjm commented Oct 3, 2018

bors-servo commented Oct 3, 2018

bors-servo commented Oct 3, 2018

SimonSapin commented Oct 3, 2018

SimonSapin commented Oct 3, 2018

bors-servo commented Oct 3, 2018

ferjm commented Oct 8, 2018

bors-servo commented Oct 8, 2018

bors-servo commented Oct 8, 2018

ferjm commented Oct 8, 2018

bors-servo commented Oct 8, 2018

bors-servo commented Oct 8, 2018

jdm commented Oct 8, 2018

ferjm commented Oct 8, 2018

SimonSapin commented Oct 30, 2018

ferjm commented Nov 2, 2018

bors-servo commented Nov 2, 2018

ferjm commented Nov 2, 2018

bors-servo commented Nov 2, 2018

bors-servo commented Nov 2, 2018

ferjm commented Nov 2, 2018

ferjm commented Nov 5, 2018

bors-servo commented Nov 5, 2018

bors-servo commented Nov 5, 2018

ferjm commented Nov 5, 2018

ferjm commented Nov 5, 2018

bors-servo commented Nov 5, 2018

bors-servo commented Nov 5, 2018

bors-servo commented Nov 5, 2018

ferjm commented Oct 3, 2018 •

edited