New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ctx.putImageData #21868

Merged
merged 3 commits into from Oct 5, 2018

Conversation

Projects
None yet
5 participants
@nox
Member

nox commented Oct 4, 2018

This change is Reviewable

@highfive

This comment has been minimized.

highfive commented Oct 4, 2018

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/canvasrenderingcontext2d.rs, components/script/Cargo.toml, components/script/dom/webidls/CanvasRenderingContext2D.webidl
  • @KiChjang: components/script/dom/canvasrenderingcontext2d.rs, components/script/Cargo.toml, components/script/dom/webidls/CanvasRenderingContext2D.webidl
@highfive

This comment has been minimized.

highfive commented Oct 4, 2018

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@nox

This comment has been minimized.

Member

nox commented Oct 4, 2018

@bors-servo try=wpt

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 4, 2018

⌛️ Trying commit 97fcf3e with merge 3faacd8...

bors-servo added a commit that referenced this pull request Oct 4, 2018

Auto merge of #21868 - servo:webgl, r=<try>
 Improve ctx.putImageData
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 4, 2018

💔 Test failed - linux-rel-css

@nox nox force-pushed the webgl branch from 97fcf3e to c788984 Oct 4, 2018

@highfive highfive removed the S-tests-failed label Oct 4, 2018

@nox nox force-pushed the webgl branch from c788984 to 7a98cfa Oct 5, 2018

@jdm

This comment has been minimized.

Member

jdm commented Oct 5, 2018

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 5, 2018

📌 Commit 7a98cfa has been approved by jdm

@highfive highfive assigned jdm and unassigned Manishearth Oct 5, 2018

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 5, 2018

⌛️ Testing commit 7a98cfa with merge 04e1128...

bors-servo added a commit that referenced this pull request Oct 5, 2018

Auto merge of #21868 - servo:webgl, r=jdm
 Improve ctx.putImageData

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21868)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 5, 2018

💔 Test failed - linux-rel-css

nox added some commits Oct 4, 2018

Align canvas.putImageData with spec
The arguments are supposed to be long values, not floats.
Improve gl.putImageData
This commit should allow us to send smaller blobs to the canvas thread,
I made it into its own commit just to try=wpt.

@nox nox force-pushed the webgl branch from 7a98cfa to 82c7d71 Oct 5, 2018

@nox

This comment has been minimized.

Member

nox commented Oct 5, 2018

@bors-servo r=jdm

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 5, 2018

📌 Commit 82c7d71 has been approved by jdm

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 5, 2018

⌛️ Testing commit 82c7d71 with merge 987e376...

bors-servo added a commit that referenced this pull request Oct 5, 2018

Auto merge of #21868 - servo:webgl, r=jdm
 Improve ctx.putImageData

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21868)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 5, 2018

💔 Test failed - linux-rel-wpt

@jdm

This comment has been minimized.

Member

jdm commented Oct 5, 2018

@bors-servo retry

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 5, 2018

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 5, 2018

@bors-servo bors-servo merged commit 82c7d71 into master Oct 5, 2018

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment