New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make JNI code more robust and introduce antialiasing option #21871

Merged
merged 2 commits into from Oct 6, 2018

Conversation

Projects
None yet
5 participants
@paulrouget
Contributor

paulrouget commented Oct 5, 2018

This throws exceptions in various places. Trying to reduce the amount of unwrap/expect.


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #21306 (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable

@highfive

This comment has been minimized.

highfive commented Oct 5, 2018

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!

@paulrouget paulrouget force-pushed the paulrouget:servooptions branch from efdbdaa to 00bda0d Oct 5, 2018

@jdm

This comment has been minimized.

Member

jdm commented Oct 5, 2018

@bors-servo r+
Good cleanup!

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 5, 2018

📌 Commit 00bda0d has been approved by jdm

@highfive highfive assigned jdm and unassigned ferjm Oct 5, 2018

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 5, 2018

⌛️ Testing commit 00bda0d with merge b35d91d...

bors-servo added a commit that referenced this pull request Oct 5, 2018

Auto merge of #21871 - paulrouget:servooptions, r=jdm
Make JNI code more robust and introduce antialiasing option

This throws exceptions in various places. Trying to reduce the amount of unwrap/expect.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #21306 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21871)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 5, 2018

💔 Test failed - linux-rel-wpt

let enable_subpixel_text_antialiasing = !debug_options.disable_subpixel_aa && PREFS
.get("gfx.subpixel-text-antialiasing.enabled")
.as_boolean()
.unwrap();

This comment has been minimized.

@jdm

jdm Oct 5, 2018

Member

This preference needs to be added to prefs.json.

@paulrouget paulrouget force-pushed the paulrouget:servooptions branch from 00bda0d to 5ddb8d5 Oct 6, 2018

@paulrouget

This comment has been minimized.

Contributor

paulrouget commented Oct 6, 2018

@bors-servo r=jdm

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 6, 2018

📌 Commit 5ddb8d5 has been approved by jdm

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 6, 2018

⌛️ Testing commit 5ddb8d5 with merge 65710be...

bors-servo added a commit that referenced this pull request Oct 6, 2018

Auto merge of #21871 - paulrouget:servooptions, r=jdm
Make JNI code more robust and introduce antialiasing option

This throws exceptions in various places. Trying to reduce the amount of unwrap/expect.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #21306 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21871)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 6, 2018

@bors-servo bors-servo merged commit 5ddb8d5 into servo:master Oct 6, 2018

2 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment