Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMake `mach test-unit` not recompile components after `mach build` #21884
Conversation
highfive
commented
Oct 7, 2018
|
Heads up! This PR modifies the following files:
|
|
r? @paulrouget |
This was referenced Oct 7, 2018
Previously, the `tests` feature flag of the `embedder_traits` crate caused it and every crate recursively depending on it to be built twice. This feature flag was used to provide a specific set of "resources" when running tests. Instead, this commits overrides the `main()` function of the test harness to change resources at runtime before running any test. This is done by adding a dependency that has `name = "test"` in its `[lib]` section of `Cargo.toml`. This overrides the crate found by `extern crate test;` in code generated by `rustc --test`.
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 7, 2018
Make `mach test-unit` not recompile components after `mach build` Previously, the `tests` feature flag of the `embedder_traits` crate caused it and every crate recursively depending on it to be built twice. This feature flag was used to provide a specific set of "resources" when running tests. Instead, this commits overrides the `main()` function of the test harness to change resources at runtime before running any test. This is done by adding a dependency that has `name = "test"` in its `[lib]` section of `Cargo.toml`. This overrides the crate found by `extern crate test;` in code generated by `rustc --test`. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21884) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
SimonSapin commentedOct 7, 2018
•
edited
Previously, the
testsfeature flag of theembedder_traitscrate caused it and every crate recursively depending on it to be built twice.This feature flag was used to provide a specific set of "resources" when running tests. Instead, this commits overrides the
main()function of the test harness to change resources at runtime before running any test.This is done by adding a dependency that has
name = "test"in its[lib]section ofCargo.toml. This overrides the crate found byextern crate test;in code generated byrustc --test.This change is